You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For eg. The image carousel can be setup to use internal links to traverse between the images, or another method is to use scrollIntoView to move the images into position or finally a method to use left property values to manually move the slider div can be used. (here are two different implementations I did: Using a combo of direct internal links and scrollIntoView calls, I created this demo https://hbar1st.github.io/demo-poster-slider/, while I changed the code later on in a different branch to use the left property to move the slider here (sorry no demo) https://github.com/hbar1st/demo-poster-slider/tree/position
I think if there is an intention that one method should be favored over another, the step can be clearer about that in its description as it currently doesn't really suggest a specific method or explicitly require one. I personally found the scrollIntoView method to be better than changing the left position (no maths, and code is easier to read plus the overall effect looks like scrolling for free without any use of animation or translation).
Just some thoughts on this exercise which will hopefully lead to either adding a hint to suggest something to the learners or being more specific that any method to move to the images will be acceptable. Thanks!
Agree the wording could do with clarification. It seems like it's alluding towards absolute positioning and manipulating left, which is also what's been taught in the previous course, but since it just says "positioning" generally and not something like "positioning" (or something more explicit), it's not clear if it expects a position-based approach or if that's actually just a generic "position the div via whatever method, including scrollIntoView if you happen to know about it".
Checks
Describe your suggestion
In the section of the JS curriculum which requests the creation of an image carousel here https://www.theodinproject.com/lessons/node-path-javascript-dynamic-user-interface-interactions, the instructions never specifically say which method they would like us to use to achieve this.
For eg. The image carousel can be setup to use internal links to traverse between the images, or another method is to use scrollIntoView to move the images into position or finally a method to use left property values to manually move the slider div can be used. (here are two different implementations I did: Using a combo of direct internal links and scrollIntoView calls, I created this demo https://hbar1st.github.io/demo-poster-slider/, while I changed the code later on in a different branch to use the left property to move the slider here (sorry no demo) https://github.com/hbar1st/demo-poster-slider/tree/position
I think if there is an intention that one method should be favored over another, the step can be clearer about that in its description as it currently doesn't really suggest a specific method or explicitly require one. I personally found the scrollIntoView method to be better than changing the left position (no maths, and code is easier to read plus the overall effect looks like scrolling for free without any use of animation or translation).
Just some thoughts on this exercise which will hopefully lead to either adding a hint to suggest something to the learners or being more specific that any method to move to the images will be acceptable. Thanks!
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-javascript-dynamic-user-interface-interactions
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: