From b62fc3e6f4266ae6da91f7b0baa490d2169f3323 Mon Sep 17 00:00:00 2001 From: Kevin Schiffer Date: Tue, 7 Feb 2023 14:47:30 +0100 Subject: [PATCH] console: Fix desired rx1 settings --- CHANGELOG.md | 1 + pkg/webui/console/components/mac-settings-section/index.js | 2 +- .../network-server-form/validation-schema.js | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ff1abc8526..fe7035a641 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ For details about compatibility between different releases, see the **Commitment ### Fixed - Key unwrap caching. +- Desired RX1 delay and desired beacon frequency not being possible to set for OTAA devices. ### Security diff --git a/pkg/webui/console/components/mac-settings-section/index.js b/pkg/webui/console/components/mac-settings-section/index.js index 69c6061714..a8ab98a6d6 100644 --- a/pkg/webui/console/components/mac-settings-section/index.js +++ b/pkg/webui/console/components/mac-settings-section/index.js @@ -150,7 +150,7 @@ const MacSettingsSection = props => { const [isCollapsed, setIsCollapsed] = React.useState(initiallyCollapsed) const handleIsCollapsedChange = React.useCallback(() => { if (!isCollapsed && pingPeriodicityRequired) { - // Do not close section if `ping_slot_perdiodicity` is required. + // Do not close section if `ping_slot_periodicity` is required. return } diff --git a/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js b/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js index 6c01bcddad..6b31a85a68 100644 --- a/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js +++ b/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js @@ -146,7 +146,7 @@ const validationSchema = Yup.object() ) }), desired_beacon_frequency: Yup.lazy(() => { - if (!isClassB || mode !== ACTIVATION_MODES.MULTICAST) { + if (!isClassB || mode === ACTIVATION_MODES.MULTICAST) { return Yup.number().strip() } @@ -180,7 +180,7 @@ const validationSchema = Yup.object() .max(15, Yup.passValues(sharedMessages.validateNumberLte)) }), desired_rx1_delay: Yup.lazy(delay => { - if (delay === undefined || delay === '' || mode !== ACTIVATION_MODES.MULTICAST) { + if (delay === undefined || delay === '' || mode === ACTIVATION_MODES.MULTICAST) { return Yup.number().strip() }