PropsType is getting undefined

[bhavinatharva]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-video-player@0.14.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-video-player/index.js b/node_modules/react-native-video-player/index.js
index ed9965b..0d55654 100644
--- a/node_modules/react-native-video-player/index.js
+++ b/node_modules/react-native-video-player/index.js
@@ -606,58 +606,58 @@ export default class VideoPlayer extends Component {
   }
 }
 
-VideoPlayer.propTypes = {
-  video: Video.propTypes.source,
-  thumbnail: ImagePropTypes.source,
-  endThumbnail: ImagePropTypes.source,
-  videoWidth: PropTypes.number,
-  videoHeight: PropTypes.number,
-  duration: PropTypes.number,
-  autoplay: PropTypes.bool,
-  paused: PropTypes.bool,
-  defaultMuted: PropTypes.bool,
-  muted: PropTypes.bool,
-  style: ViewPropTypesVar.style,
-  controlsTimeout: PropTypes.number,
-  disableControlsAutoHide: PropTypes.bool,
-  disableFullscreen: PropTypes.bool,
-  loop: PropTypes.bool,
-  resizeMode: Video.propTypes.resizeMode,
-  hideControlsOnStart: PropTypes.bool,
-  endWithThumbnail: PropTypes.bool,
-  disableSeek: PropTypes.bool,
-  pauseOnPress: PropTypes.bool,
-  fullScreenOnLongPress: PropTypes.bool,
-  customStyles: PropTypes.shape({
-    wrapper: ViewPropTypesVar.style,
-    video: Video.propTypes.style,
-    videoWrapper: ViewPropTypesVar.style,
-    controls: ViewPropTypesVar.style,
-    playControl: ViewPropTypesVar.style,
-    controlButton: ViewPropTypesVar.style,
-    controlIcon: Icon.propTypes.style,
-    playIcon: Icon.propTypes.style,
-    seekBar: ViewPropTypesVar.style,
-    seekBarFullWidth: ViewPropTypesVar.style,
-    seekBarProgress: ViewPropTypesVar.style,
-    seekBarKnob: ViewPropTypesVar.style,
-    seekBarKnobSeeking: ViewPropTypesVar.style,
-    seekBarBackground: ViewPropTypesVar.style,
-    thumbnail: ImagePropTypes.style,
-    playButton: ViewPropTypesVar.style,
-    playArrow: Icon.propTypes.style,
-    durationText: ViewPropTypesVar.style
-  }),
-  onEnd: PropTypes.func,
-  onProgress: PropTypes.func,
-  onLoad: PropTypes.func,
-  onStart: PropTypes.func,
-  onPlayPress: PropTypes.func,
-  onHideControls: PropTypes.func,
-  onShowControls: PropTypes.func,
-  onMutePress: PropTypes.func,
-  showDuration: PropTypes.bool
-};
+// VideoPlayer.propTypes = {
+//   video: Video.propTypes.source,
+//   thumbnail: ImagePropTypes.source,
+//   endThumbnail: ImagePropTypes.source,
+//   videoWidth: PropTypes.number,
+//   videoHeight: PropTypes.number,
+//   duration: PropTypes.number,
+//   autoplay: PropTypes.bool,
+//   paused: PropTypes.bool,
+//   defaultMuted: PropTypes.bool,
+//   muted: PropTypes.bool,
+//   style: ViewPropTypesVar.style,
+//   controlsTimeout: PropTypes.number,
+//   disableControlsAutoHide: PropTypes.bool,
+//   disableFullscreen: PropTypes.bool,
+//   loop: PropTypes.bool,
+//   resizeMode: Video.propTypes.resizeMode,
+//   hideControlsOnStart: PropTypes.bool,
+//   endWithThumbnail: PropTypes.bool,
+//   disableSeek: PropTypes.bool,
+//   pauseOnPress: PropTypes.bool,
+//   fullScreenOnLongPress: PropTypes.bool,
+//   customStyles: PropTypes.shape({
+//     wrapper: ViewPropTypesVar.style,
+//     video: Video.propTypes.style,
+//     videoWrapper: ViewPropTypesVar.style,
+//     controls: ViewPropTypesVar.style,
+//     playControl: ViewPropTypesVar.style,
+//     controlButton: ViewPropTypesVar.style,
+//     controlIcon: Icon.propTypes.style,
+//     playIcon: Icon.propTypes.style,
+//     seekBar: ViewPropTypesVar.style,
+//     seekBarFullWidth: ViewPropTypesVar.style,
+//     seekBarProgress: ViewPropTypesVar.style,
+//     seekBarKnob: ViewPropTypesVar.style,
+//     seekBarKnobSeeking: ViewPropTypesVar.style,
+//     seekBarBackground: ViewPropTypesVar.style,
+//     thumbnail: ImagePropTypes.style,
+//     playButton: ViewPropTypesVar.style,
+//     playArrow: Icon.propTypes.style,
+//     durationText: ViewPropTypesVar.style
+//   }),
+//   onEnd: PropTypes.func,
+//   onProgress: PropTypes.func,
+//   onLoad: PropTypes.func,
+//   onStart: PropTypes.func,
+//   onPlayPress: PropTypes.func,
+//   onHideControls: PropTypes.func,
+//   onShowControls: PropTypes.func,
+//   onMutePress: PropTypes.func,
+//   showDuration: PropTypes.bool
+// };
 
 VideoPlayer.defaultProps = {
   videoWidth: 1280,

This issue body was partially generated by patch-package.

[hzhoanglee]

As I see, they are identical. Or am I missing something?

[mlazari]

As I see, they are identical. Or am I missing something?

@hzhoanglee I think you're missing that it's just commenting out those lines, not replacing them with something else. Video.propTypes is undefined with the latest react-native-video versions, which makes that code throw an error.