Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to all instructions which are extensions #5

Closed
ThinkOpenly opened this issue Nov 10, 2023 · 3 comments
Closed

Add tags to all instructions which are extensions #5

ThinkOpenly opened this issue Nov 10, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@ThinkOpenly
Copy link
Owner

Many extensions include discriminators which clearly tag instructions which are included in the extension:

mapping clause encdec = RISCV_FMINM_S(rs2, rs1, rd)     if haveZfa()

(Note that issue #4 suggests a more robust tagging method.)

Not all extensions are well-tagged, however, especially if they are ratified and included in the "base ISA":

/* This file specifies the compressed instructions in the 'C' extension. */
[...]
mapping clause encdec_compressed = C_LW(ui6 @ ui53 @ ui2, rs1, rd)

It would be useful to include tags for these instructions as well, hopefully in a robust way as suggested in issue #4.

@AbhinavMir
Copy link

I think this can be closed since Sanket seems to have implemented this?

@ThinkOpenly
Copy link
Owner Author

I'd like see an audit performed that shows this is reasonably complete and accurate.

@ThinkOpenly ThinkOpenly added the good first issue Good for newcomers label Jun 21, 2024
@ThinkOpenly
Copy link
Owner Author

Our upstream PR for this work riscv#506 has been merged! 🎉 Thanks for everyone's efforts on this!

Closing this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants