Remove Deref bounds from containers #416
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a pervasive
Deref
bound on containers withindex
andlen
methods, and reworkscopy_slice
intocopy_range
. Now that I type it, we could probably keepcopy_slice
, as implementing it is not hard (rather dereferencing to form the input slice).Ideally we would use
std::ops::Index
but this makes life terrible when we elsewhere writecontainer[..]
or the like to get a slice, and instead run afoul of..
not being ausize
for theIndex
implementation. Perhaps this could be cleaned up and made more pleasant before landing.cc: @antiguru