Only retain two allocations #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes retaining memory as large as the output when sealing the merge batcher for columnation. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
|
This makes sense to me, after conversation with you! |
|
Confirming that it fixes the issue observed in https://github.com/MaterializeInc/database-issues/issues/7033. |
vmarcos
pushed a commit
to MaterializeInc/differential-dataflow
that referenced
this pull request
Nov 23, 2023
This fixes retaining memory as large as the output when sealing the merge batcher for columnation. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
sploiselle
pushed a commit
to sploiselle/materialize
that referenced
this pull request
Nov 24, 2023
This commit makes Materialize use a branched version of DD that is compatible with the v0.78 series and includes the fix to a memory allocation spike in TimelyDataflow/differential-dataflow#425.
antiguru
added a commit
to antiguru/differential-dataflow
that referenced
this pull request
Nov 25, 2023
A follow-up to TimelyDataflow#425. Retain two elements instead of three in the stash. Avoid doubling reallocations in the first `keep` object. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
added a commit
to antiguru/differential-dataflow
that referenced
this pull request
Nov 25, 2023
A follow-up to TimelyDataflow#425. Retain two elements instead of three in the stash. Avoid doubling reallocations in the first `keep` object. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry
pushed a commit
that referenced
this pull request
Nov 25, 2023
A follow-up to #425. Retain two elements instead of three in the stash. Avoid doubling reallocations in the first `keep` object. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes retaining memory as large as the output when sealing the merge batcher for columnation.