Introduce generic consolidator #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's improved: |
Currently slightly slower than the existing in-place consolidate, mostly because it needs to copy the keys. test consolidation::tests::test_consolidator_duration ... elapsed consolidator 3.956388988s ok test consolidation::tests::test_consolidator_duration_vec ... elapsed vec 3.652386365s Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Move instead of clone Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Correct logic Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Consolidator does not sort Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Explicitly specify target container Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Make it a trait, not sure if better Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Consolidator on batcher Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
|
Closing in favor of #494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently slightly slower than the existing in-place consolidate, mostly because it needs to copy the keys.
test consolidation::tests::test_consolidator_duration ... elapsed consolidator 3.956388988s ok
test consolidation::tests::test_consolidator_duration_vec ... elapsed vec 3.652386365s