From 94c01c610a4715b1595c35af53828acbc9fa530c Mon Sep 17 00:00:00 2001 From: Tobias Hartmann Date: Tue, 13 Aug 2024 06:08:04 +0000 Subject: [PATCH] 8336779: [lworld] C2 compilations hits "what's left behind is null" assert in do_checkcast --- src/hotspot/share/opto/graphKit.cpp | 1 + .../inlinetypes/TestUnloadedCastType.java | 59 +++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnloadedCastType.java diff --git a/src/hotspot/share/opto/graphKit.cpp b/src/hotspot/share/opto/graphKit.cpp index 29cee6f74a9..28570e7992b 100644 --- a/src/hotspot/share/opto/graphKit.cpp +++ b/src/hotspot/share/opto/graphKit.cpp @@ -1299,6 +1299,7 @@ Node* GraphKit::null_check_common(Node* value, BasicType type, // vtptr = InlineTypeNode::make_null(_gvn, vtptr->type()->inline_klass()); // replace_in_map(value, vtptr); // return vtptr; + replace_in_map(value, null()); return null(); } bool do_replace_in_map = (null_control == nullptr || (*null_control) == top()); diff --git a/test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnloadedCastType.java b/test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnloadedCastType.java new file mode 100644 index 00000000000..d9dd67e7c41 --- /dev/null +++ b/test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnloadedCastType.java @@ -0,0 +1,59 @@ +/* + * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @summary Test casting of value objects to an unloaded type. + * @enablePreview + * @library /test/lib + * @run main/othervm -Xbatch -XX:CompileCommand=dontinline,TestUnloadedCastType::test* + * TestUnloadedCastType + */ + +import jdk.test.lib.Asserts; + +public class TestUnloadedCastType { + + static value class MyValue { + int x = 0; + } + + static class Unloaded { } + + public static Object test(MyValue val) { + Object obj = val; + return (Unloaded)obj; + } + + public static void main(String[] args) { + for (int i = 0; i < 50_000; ++i) { + Asserts.assertEQ(test(null), null); + } + try { + test(new MyValue()); + throw new RuntimeException("No ClassCastException thrown"); + } catch (ClassCastException e) { + // Expected + } + } +}