Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start ICO by calling function functionality #161

Open
agnesenvaite opened this issue May 18, 2019 · 0 comments
Open

Start ICO by calling function functionality #161

agnesenvaite opened this issue May 18, 2019 · 0 comments

Comments

@agnesenvaite
Copy link

I am analyzing features in publicly available ICO smart contracts as my Bachelor's thesis. In the thesis I am comparing how features in ICO smart contracts evolve naturally and in ICO libraries.

In my analysis I selected smart contracts labelled with "token sale" and having more then 700 transactions. Total count of such contracts was 161.

I selected 40 smart contracts which do not have token functionality (thesis scope was ICO smart contracts alone). I used selected smart contracts to create a feature model. Also, I created features model of TokenMarket ICO smart contracts. I compared them. One of the missing features is start ICO by calling function.

15% (6 of 40) of ICO smart contracts have start ICO by calling function functionality. I suggest creating StartableCrowdsale smart contract which extends CrowdsaleBase smart contract.

Proposed code for start ICO by calling function feature:

import "./CrowdsaleBase.sol";

contract StartableCrowdsale is CrowdsaleBase{

  event StartAtChanged(uint newStartAt);

  constructor  (address _token, PricingStrategy _pricingStrategy, 
  address _multisigWallet, uint _start, uint _end, uint _minimumFundingGoal)
    CrowdsaleBase (_token, _pricingStrategy, _multisigWallet, 
    _start, _end, _minimumFundingGoal) public{}
    /**
    * @dev Start Crowdsale
    */
    function startCrowdsale () public onlyOwner inState(State.PreFunding){
      startsAt = now;
      StartAtChanged(startsAt);
    }
}
agnesenvaite added a commit to agnesenvaite/smart-contracts that referenced this issue May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@agnesenvaite and others