Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support online videos #12

Open
wwjCMP opened this issue Sep 16, 2023 · 1 comment
Open

[FR] Support online videos #12

wwjCMP opened this issue Sep 16, 2023 · 1 comment
Assignees
Labels
FR New feature or request icebox requires signifigant lift and is not planned at this time

Comments

@wwjCMP
Copy link

wwjCMP commented Sep 16, 2023

Thank you very much for the continuous maintenance and feature updates of this plugin; you've done an excellent job, and it now mostly meets my needs. Here's a personal request from me:

Could you please add a feature to parse video URLs embedded in HTML syntax within Markdown files and enable the display of online videos in the gallery?

Here's the situation: When I'm building my movie and TV show information database, I often prefer embedding the real online video URLs to save local storage space, rather than embedding local videos. I use the following simple HTML syntax for that purpose.

If the gallery could support displaying online videos, that would be fantastic, even though I understand it's a special requirement for me.

Lastly, thank you for your hard work."

<video width="1080" height="480" controls> <source src="https://imdb-video.media-imdb.com/vi2053751833/1434659607842-pgv4ql-1683541736696.mp4?Expires=1694940366&Signature=iYFrYTE9Ik97nC8cegOuVLf56gpxxjFEBGuwED4NvL9qXkOqHl0wCQg4srMBy4tTTiKKQn-s~n9ijEKg9YYxqTliDK~Br2bm8n1OkFgzohwGA2MAO92ZE7fAIbIhchpEKr1Nse92jDIUPfuBPdvhpmkI65BEgE3oB61K9x4EfTvYTlBl3bF5Hhrla2L~sgN5zX9GWl~dA5oubDTXJa3Xav4JROoi6aIIwb-Iu1b0TXawvnvXiCZJUYec07cD6miyRkqtyEkqw4N1m2jgwl0ttX-yNm1dKaoUhV92DQJJjbamEkNGAq49uUM2Qudp4d~IiP9uSEGpRpp14dYfnMxZJA__&Key-Pair-Id=APKAIFLZBVQZ24NQH3KA" type="video/mp4"></video>
@TomNCatz TomNCatz added the FR New feature or request label Sep 16, 2023
@TomNCatz
Copy link
Owner

This falls well outside of the capabilities and goals of the current plugin, but I can understand the value of a feature like this.
Gonna put this in the icebox for later, but I'm going to take some design note for when I come back to it. If you have notes of your own to add about what and how you would like it to function feel free to add them as a comment.

  • Walking the whole vault for embeds is a lot and would sort of fell like a privacy concern if I'm not careful how I do it. If I add an option to include ANY embeds from the whole project I'll probably gate it behind a setting you have to turn on.
  • Preferred method would be to add a context menu option for all embeds that you can generate a meta file for the embed itself and then I could allow for galleries to include the embed in a search based on the meta file existing. This is an extra step to include it, but means that only embeds the user wants in would go in (and I don't have to paw through your vault files)
  • Embeds require hitting the internet to display, and one of the reasons I got started on this work was a gallery that could be accessed offline. perhaps I'll do something like I do for lazy loading images where there is a specific 'loading embed' image and if the embed is not actually available (either because there is not internet or the file is not currently available) then it simply will not switch over. I might also include an option to not load embeds until they are clicked on.
  • Currently, the first filter used to determine if an image should be in a gallery view is where the image is located in the project. To include embeds(which don't reside in the project at all) I'd need to come up with a new strategy. Perhaps make it so that you can target the folder the meta files are in?
  • There is more than one format a user can use to embed an image in a file, and I'll have to figure out how to handle each of them.

@TomNCatz TomNCatz added the icebox requires signifigant lift and is not planned at this time label Sep 16, 2023
@TomNCatz TomNCatz self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR New feature or request icebox requires signifigant lift and is not planned at this time
Projects
None yet
Development

No branches or pull requests

2 participants