-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private functions used in overridable methods? #204
Comments
Good questions. The private methods can probably be made protected. Might make a good PR if you are interested. 😄 |
Haven't really contributed much before but I could give it a go 😃 |
Might make for a good first PR. See the contributing guidelines to how to get started. |
Would we want all of _options accessible or would it be better just to make a protected property that accesses the one property within _options? And should it return false when _options is null? something like |
Not a bad idea to make the options protected. |
Not sure if this qualifies as a "bug", but when attempting to override
GenerateProperties
by copy/pasting the existing code and modifying I'm met with the dreaded red squiggles because the original Method uses private properties and methods.. I can copy/paste those too, but if it ever changes I won't get those changes. Would it be better if they were public or internal?The text was updated successfully, but these errors were encountered: