500 when accepting follow requests

[HerrLevin]

Describe the bug

In very rare cases it's possible to provoke an error 500 (AlreadyFollowingException) when accepting a follow request

Steps to reproduce

This cannot easily be reproduced without manipulating the database.

1. Table follows

id|user_id|follow_id|created_at             |updated_at             |
--+-------+---------+-----------------------+-----------------------+
 1|      1|        2|2024-04-19 13:07:10.000|2024-04-19 13:07:10.000|

2. Table follow_requests

id|user_id|follow_id|created_at             |updated_at             |
--+-------+---------+-----------------------+-----------------------+
 1|      1|        2|2024-04-19 12:00:01.000|2024-04-19 12:00:01.000|

3. Accept follow-reqeust

Browser console logs

No response

Browser

No response

[HerrLevin]

Idea: try/catch around the follow acceptance and just remove the follow request if THIS exception occurs

[MrKrisKrisu]

I cannot find the cause of your problem. We have two endpoints APIv1 and legacy frontend. Both Endpoints catches the AlreadyFollowingException and don't return HTTP 500 then.

traewelling/app/Http/Controllers/API/v1/FollowController.php

Lines 63 to 64 in a55c811

	} catch (AlreadyFollowingException) {
	return $this->sendError(['message' => __('controller.user.follow-error')], 409);

traewelling/app/Http/Controllers/FrontendUserController.php

Lines 78 to 79 in a55c811

	} catch (AlreadyFollowingException) {
	return response()->json(['message' => __('controller.user.follow-request-already-exists')], 409);

[HerrLevin]

No, it's in

traewelling/app/Http/Controllers/Backend/User/FollowController.php

Lines 70 to 79 in a55c811

	public static function approveFollower(int $userId, int $approverId): bool {
	$request = FollowRequest::where('user_id', $approverId)->where('follow_id', $userId)->firstOrFail();
	$follow = UserController::createFollow($request->user, $request->requestedFollow, true);
	if ($follow) {
	$request->delete();
	}
	return $follow;
	}