Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in status messages not clickable but coincidentally contained Träwelling usernames clickable #2661

Open
pascalwittler opened this issue Jun 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@pascalwittler
Copy link
Contributor

pascalwittler commented Jun 4, 2024

Describe the bug

After posting a status message with a link to one of my own Mastodon posts [1], I noticed that the link was not clickable. My Mastodon username contained in the link is the same as my Träwelling username – and it turns out to be clickable with my Träwelling profile as the link target.

My expectation would be that text parts of status messages that can be parsed as valid URLs would be rendered as clickable links and they would be evaluated with higher priority than substrings.

[1] My status message including my clickable username and the unclickable link

1

Steps to reproduce

  1. Create a status message in your check-in
  2. Insert a URL containing a valid Träwelling username

Browser console logs

No response

Browser

No response

@pascalwittler pascalwittler added the bug Something isn't working label Jun 4, 2024
@MrKrisKrisu
Copy link
Member

I'm not sure if I would really call that a “bug”. I wouldn't link external links.

However, the internal mention could perhaps be limited to the extent that it is only a mention if there are no other characters before or after.

@pascalwittler
Copy link
Contributor Author

pascalwittler commented Jun 4, 2024

I definitely see your point.

Only evaluating a mention without non-space characters before and after it could lead in false negatives, for example in comma separated lists (as in „On the way to event XY with @user1, @user2 and @user3“).

Feel free to remove the „bug“ label. It was added automatically after I had to choose between creating an issue or a discussion by the forced templates.

@HerrLevin HerrLevin added enhancement New feature or request and removed bug Something isn't working labels Jun 11, 2024
@pascalwittler pascalwittler changed the title Links in status messages not clickable but coincidentally containing Träwelling usernames clickable Links in status messages not clickable but coincidentally contained Träwelling usernames clickable Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants