Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write error log when topic is not created #59

Closed
keremcankabadayi opened this issue Oct 19, 2023 · 3 comments
Closed

write error log when topic is not created #59

keremcankabadayi opened this issue Oct 19, 2023 · 3 comments
Assignees
@keremcankabadayi @dilaragorum
Labels
enhancement New feature or request

Comments

@keremcankabadayi
Copy link
Contributor 

Reader: kafka.ReaderConfig{
			Brokers:        strings.Split(getConsumerServers(a.Kafka), ","),
			GroupID:        consumerCfg.ConsumerGroup,
			GroupTopics:    consumerCfg.Topics,
			MaxWait:        2 * time.Second,
			CommitInterval: time.Second,
			Logger:         l,
			ErrorLogger:    l,
		},

I added logger and error logger. I would be great if we saw log about topic not found or smth.
@Abdulsametileri
Copy link
Member

Thank you! We can ask this question to the segmentio-kafkago @keremcankabadayi

@Abdulsametileri Abdulsametileri added the enhancement New feature or request label Dec 10, 2023
@keremcankabadayi keremcankabadayi self-assigned this Jan 5, 2024
keremcankabadayi added a commit to keremcankabadayi/kafka-konsumer that referenced this issue Feb 26, 2024
@keremcankabadayi
feat: added topic exists check (Trendyol#59)
72deca3
@Abdulsametileri
Copy link
Member

segmentio/kafka-go#1142 here related issue,
@dilaragorum will also check related pr #111

Abdulsametileri pushed a commit that referenced this issue Jun 3, 2024
@keremcankabadayi
feat: added topic exists check (#59) (#131)
ca225fb 
* feat: added topic exists check (#59)

* chore:

* chore: dummy

* feat: implement topic verify process

* chore: lint fix

* feat: bump kafka-cronsumer verify topic commit

* feat: add verifyTopicOnStartup flag

---------

Co-authored-by: keremcankabadayi <keremcankabadayi@gmail.com>
@Abdulsametileri
Copy link
Member

implemented, thank you for your contribution @keremcankabadayi <3 commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keremcankabadayi keremcankabadayi

@dilaragorum dilaragorum

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Abdulsametileri @keremcankabadayi @dilaragorum