Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an English version of geographic areas which are not written in Latin characters #166

Open
TrevorPilley opened this issue Jun 17, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@TrevorPilley
Copy link
Owner

Whilst the library intends to show the geographic area name in the local spelling, for non Latin alphabets (e.g. Hebrew, Arabic and Cyrillic) or script based (e.g. Chinese and Japanese) it would be helpful for the library to also show the English translation.

@TrevorPilley TrevorPilley modified the milestones: 2.3.0, 2.2.0 Jun 17, 2021
@TrevorPilley TrevorPilley modified the milestones: 2.2.0, 2.3.0 Jul 20, 2021
@TrevorPilley TrevorPilley added the enhancement New feature or request label Dec 7, 2021
@TrevorPilley TrevorPilley removed this from the 2.5.0 milestone Dec 31, 2021
@TrevorPilley TrevorPilley added this to the 2.10.0 milestone Oct 26, 2022
@TrevorPilley TrevorPilley modified the milestones: 2.10.0, 2.11.0, 3.0.0 Dec 12, 2022
@TrevorPilley
Copy link
Owner Author

TrevorPilley commented Jan 23, 2023

One idea is to follow the same approach used in RegionInfo and have string GeographicAreaEnglish { get; } alongside a string GeographicAreaNative { get; } the existing string GeographicArea { get; } would then return the appropriate value based upon the current culture (native if a match, English if not)

@TrevorPilley TrevorPilley removed this from the 3.0.0 milestone Mar 17, 2023
@TrevorPilley
Copy link
Owner Author

TrevorPilley commented Apr 4, 2023

Another idea is to have region specific translations which is just a dictionary of name changes and a GetName(CultureInfo) method which would then read from a file (translations/IT/EN.txt) with content something like this - Firenze|Florence this would be more flexible and support translations between any languages it was coded for but also a lot more effort to populate and maintain.

@TrevorPilley TrevorPilley added this to the 4.0.0 milestone May 20, 2023
@TrevorPilley
Copy link
Owner Author

Also consider if the equivalent should apply for the country name on CountryInfo

@TrevorPilley
Copy link
Owner Author

Think about how this can be implemented in a consistent way as at present CountryInfo.Name is always in English but GeographicPhoneNumber.GeographicArea is in the locality of the country where possible.

@TrevorPilley
Copy link
Owner Author

CountryInfo.Name is changed to return the name of the country the native language of the country, CountryInfo.NameEnglish is added to return the name of the country in English.

@TrevorPilley TrevorPilley self-assigned this Apr 14, 2024
@TrevorPilley TrevorPilley modified the milestones: 4.0.0, 5.0.0 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant