Issue#283 - User authentication (Sign up) successful

[Lanaanvar]

Description

A clear and concise description of what the PR does.

• This PR does the following:
  • Fixes user authentication error during Sign up

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

• Placeholder: "Fixes Working on the user authentication in the sign up page #283 "

Changes

List the detailed changes made in this PR.

• Fixed a bug in Sign Up page due to multiple sending of tokens after signing up

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

1. Pull this branch.
2. Run npm install to install dependencies.
3. Run npm test to execute the test suite.
4. Verify that valid MONGO_URL exists

Screenshots (if applicable)

Additional Context

Any additional context or information that reviewers should be aware of.

• After signing up, login in using the same email and password.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I am working on this issue under GSSOC

[github-actions]

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

[Trisha-tech]

Description

A clear and concise description of what the PR does.

• This PR does the following:

  • Fixes user authentication error during Sign up

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

• Placeholder: "Fixes Working on the user authentication in the sign up page #283 "

Changes

List the detailed changes made in this PR.

• Fixed a bug in Sign Up page due to multiple sending of tokens after signing up

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

1. Pull this branch.
2. Run npm install to install dependencies.
3. Run npm test to execute the test suite.
4. Verify that valid MONGO_URL exists

Screenshots (if applicable)

Additional Context

Any additional context or information that reviewers should be aware of.

• After signing up, login in using the same email and password.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I am working on this issue under GSSOC

Kindly resolve these conflicts @Lanaanvar

[Lanaanvar]

how do i resolve this issue? Not able to click the resolve conflict button

[Lanaanvar]

Is this okay?

[Suman373]

Is this okay?

There is conflict in package lock file. You can remove your own package-lock and keep the updated one from the master branch.

[Suman373]

I am not able to understand where the bug was.

1. Status code was changed
2. The response with customer object was changed

[Lanaanvar]

I'll explain the issue. When a customer signs up in the registration page, it shows : "An error occurred. Please try again later.". So I checked the backend code and found the problem that was causing this : The original code had multiple calls to sendToken(customer, 201, res). It was also sending multiple responses. So i did the following :

1. Removed the duplicate call to sendToken(customer, 201, res).
2. Only a single response is sent with all the required information, including the refreshToken, customer, and optional token.
3. Changed the status code from 404 to 400 for invalid requests, as it’s more appropriate for bad requests.
4. Explicitly included only necessary fields from the customer object in the response.

I hope this is understandable.

[Suman373]

I'll explain the issue. When a customer signs up in the registration page, it shows : "An error occurred. Please try again later.". So I checked the backend code and found the problem that was causing this : The original code had multiple calls to sendToken(customer, 201, res). It was also sending multiple responses. So i did the following :

1. Removed the duplicate call to sendToken(customer, 201, res).

2. Only a single response is sent with all the required information, including the refreshToken, customer, and optional token.

3. Changed the status code from 404 to 400 for invalid requests, as it’s more appropriate for bad requests.

4. Explicitly included only necessary fields from the customer object in the response.

I hope this is understandable.

Yes, this is comprehensive and understandable. Great work !! 👍
@Trisha-tech You may verify and merge