-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added book info page #597
Added book info page #597
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@Sourabh782 Hey ! Nice work ! 👍 |
Sure I tried it, but size was not increasing, still I'll look into it |
You have given a max-width to the parent and have fixed the width of both image and details part. Try to adjust both image and details width. |
@Suman373 i have fixed that issue also fixed responsiveness issue : |
@Sourabh782 Great work ! 🙌 I hope all the other images are looking like this. |
Yes the images src are added at image so all are working, I can share video of it |
Not necessary ! |
@Trisha-tech can you check this pr? |
Kindly look into this once, details of the book are not showing. @Sourabh782 |
Can you share ss? |
Description
A clear and concise description of what the PR does.
Related Issues
Link any related issues using the format
Fixes #issue_number
.This helps to automatically close related issues when the PR is merged.
Changes
List the detailed changes made in this PR.
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm install
to install dependencies.npm test
to execute the test suite.Screenshots (if applicable)
Online.Book.Sales.-.Google.Chrome.2024-10-22.22-03-07.mp4
Additional Context
Any additional context or information that reviewers should be aware of.
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.