Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added book info page #597

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Added book info page #597

merged 3 commits into from
Oct 29, 2024

Conversation

Sourabh782
Copy link
Contributor

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    • Adds ...
    • Fixes ...
    • Updates ...

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... view book page
  • Refactored the ...
  • Fixed a bug in ...

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Online.Book.Sales.-.Google.Chrome.2024-10-22.22-03-07.mp4

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Suman373
Copy link
Collaborator

@Sourabh782 Hey ! Nice work ! 👍
I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

@Sourabh782
Copy link
Contributor Author

@Sourabh782 Hey ! Nice work ! 👍 I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

Sure I tried it, but size was not increasing, still I'll look into it

@Suman373
Copy link
Collaborator

Suman373 commented Oct 23, 2024

@Sourabh782 Hey ! Nice work ! 👍 I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

Sure I tried it, but size was not increasing, still I'll look into it

You have given a max-width to the parent and have fixed the width of both image and details part. Try to adjust both image and details width.

@Sourabh782
Copy link
Contributor Author

@Suman373 i have fixed that issue also fixed responsiveness issue :
Screenshot 2024-10-23 204506
Screenshot 2024-10-23 204455

@Suman373
Copy link
Collaborator

@Sourabh782 Great work ! 🙌 I hope all the other images are looking like this.
@Trisha-tech verify and merge this.

@Sourabh782
Copy link
Contributor Author

@Sourabh782 Great work ! 🙌 I hope all the other images are looking like this. @Trisha-tech verify and merge this.

Yes the images src are added at image so all are working, I can share video of it

@Suman373
Copy link
Collaborator

@Sourabh782 Great work ! 🙌 I hope all the other images are looking like this. @Trisha-tech verify and merge this.

Yes the images src are added at image so all are working, I can share video of it

Not necessary !

@Sourabh782
Copy link
Contributor Author

@Trisha-tech can you check this pr?

@Trisha-tech Trisha-tech merged commit f3bf43e into Trisha-tech:master Oct 29, 2024
1 check passed
@Trisha-tech
Copy link
Owner

@Trisha-tech can you check this pr?

Kindly look into this once, details of the book are not showing. @Sourabh782

@Sourabh782
Copy link
Contributor Author

@Trisha-tech can you check this pr?

Kindly look into this once, details of the book are not showing. @Sourabh782

Can you share ss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Detail Page as the User Clicks on the Book
3 participants