Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Redesign the signup/login both page with modern style #650

Closed
wants to merge 0 commits into from

Conversation

REHAN-18
Copy link

Description

A clear and concise description of what the PR does.

  • This PR does the following:

    • Updates ...Updates ...Redesign the signup/login both page with modern style

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.
[redesign the sign up page page /login page as well]

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@shaurya35
Copy link
Collaborator

shaurya35 commented Oct 30, 2024

@REHAN-18 since the changes should be made for signup and login, please remove the changes for Navbar and NewArrivals, I'd suggest you to create a new branch and redo the process just for the signup and login form
if you're getting any doubts, please refer this
https://github.com/Trisha-tech/OnlineBookSales/blob/master/CONTRIBUTING.md

@shaurya35
Copy link
Collaborator

@REHAN-18 also please use tailwind

@REHAN-18
Copy link
Author

REHAN-18 commented Oct 30, 2024

@REHAN-18 also please use tailwind

BRO when we run the website there are many bugs that doesnot run so that for run I changed the navbar !

@shaurya35
Copy link
Collaborator

@REHAN-18 I have fixed the code break
image

please make a pull request with the required changes, pull the latest code and just change whats required
I hope you understand

@shaurya35
Copy link
Collaborator

@REHAN-18 as mentioned your task is to improve UI for signup and login

@REHAN-18 REHAN-18 closed this Oct 30, 2024
@REHAN-18 REHAN-18 reopened this Oct 30, 2024
@REHAN-18
Copy link
Author

@REHAN-18 as mentioned your task is to improve UI for signup and login

ok I will fix &b make new pr

@REHAN-18
Copy link
Author

@REHAN-18 as mentioned your task is to improve UI for signup and login

Screenshot 2024-10-30 at 7 29 06 PM see when I run this is appear

@shaurya35
Copy link
Collaborator

@REHAN-18 as mentioned your task is to improve UI for signup and login

Screenshot 2024-10-30 at 7 29 06 PM see when I run this is appear

You will have to redirect to client directory to npm start it

@REHAN-18
Copy link
Author

@REHAN-18 as mentioned your task is to improve UI for signup and login

Screenshot 2024-10-30 at 7 29 06 PM see when I run this is appear

You will have to redirect to client directory to npm start it

yes

@REHAN-18 as mentioned your task is to improve UI for signup and login

Screenshot 2024-10-30 at 7 29 06 PM see when I run this is appear

You will have to redirect to client directory to npm start it

yes I ve done this but how I ve to check the signup/login page how they look so to open

@shaurya35
Copy link
Collaborator

@REHAN-18 i didn't get you

@REHAN-18
Copy link
Author

@REHAN-18 i didn't get you

@shaurya35 To check the UI updates of the website, I follow this process: I navigate to the client directory, run npm install, and then npm start to launch the server. However, when the server starts, I encounter an error message."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: redesign the register & login page
2 participants