Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for libraries #82

Open
Vrganj opened this issue Dec 27, 2022 · 3 comments
Open

Support for libraries #82

Vrganj opened this issue Dec 27, 2022 · 3 comments

Comments

@Vrganj
Copy link

Vrganj commented Dec 27, 2022

I can use the library by shading, but not the newer libraries feature in plugin.yml.

The issue is this:
https://github.com/TriumphTeam/triumph-gui/blob/master/core/src/main/java/dev/triumphteam/gui/guis/BaseGui.java#L67

JavaPlugin#getProvidingPlugin throws an exception since libraries aren't provided by plugins.

@Vrganj
Copy link
Author

Vrganj commented Dec 27, 2022

Same issue occurs in core/src/main/java/dev/triumphteam/gui/components/nbt/Pdc.java

@iGabyTM
Copy link
Member

iGabyTM commented Dec 27, 2022

The library depends on a plugin to register events and work with PDC, I don't think anything can be done to support spigot's libraries system.

@Vrganj
Copy link
Author

Vrganj commented Dec 27, 2022

I think the plugin that's using the library should be able to supply the instance.
Of course this can be a fallback method if you don't supply it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants