Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untracked slices still appearing in state #34

Open
dvzacharycutler opened this issue Feb 7, 2023 · 3 comments
Open

Untracked slices still appearing in state #34

dvzacharycutler opened this issue Feb 7, 2023 · 3 comments
Assignees

Comments

@dvzacharycutler
Copy link

Example here https://github.com/datavisyn/sightline/blob/mweigl/145_trrack-vis/src/store/store.ts. The untrrackedAppSlice is created with a normal createSlice call, instead of the createTrrackableSlice. It's state still appears on the node, and is still set when traversing back to this node. This creates problems, as our app doesn't expect traversing to affect this part of the store.

@dvmartinweigl
Copy link

Just wanted to mention this issue currently makes TrrackVis unusable in our application (sightline). We introcuded a toggle in the unttrackedAppSlice to handle opening/closing a drawer to render TrrackVis. Navigation within the graph is now randomly closing the drawer, because of unintentional toggle state change.

@kirangadhave
Copy link
Member

I have isolated where the issue happens. I will try to have the fix in a couple of days. I will get a beta release made for testing in the sightline project.

@dvmartinweigl
Copy link

Great to hear. Just let us now as soon the fix is in place and we will test it in sightline.

kirangadhave added a commit that referenced this issue Jun 15, 2023
untrracked slices should maintain value during undo/redo. fixed the logic to make sure this happens.
Added unit tests to test the behaviour

closes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants