-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untracked slices still appearing in state #34
Comments
Just wanted to mention this issue currently makes |
I have isolated where the issue happens. I will try to have the fix in a couple of days. I will get a beta release made for testing in the sightline project. |
Great to hear. Just let us now as soon the fix is in place and we will test it in sightline. |
untrracked slices should maintain value during undo/redo. fixed the logic to make sure this happens. Added unit tests to test the behaviour closes #34
Example here https://github.com/datavisyn/sightline/blob/mweigl/145_trrack-vis/src/store/store.ts. The untrrackedAppSlice is created with a normal createSlice call, instead of the createTrrackableSlice. It's state still appears on the node, and is still set when traversing back to this node. This creates problems, as our app doesn't expect traversing to affect this part of the store.
The text was updated successfully, but these errors were encountered: