Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackpot from dev tests #97

Open
hswick opened this issue Dec 17, 2018 · 0 comments
Open

Remove jackpot from dev tests #97

hswick opened this issue Dec 17, 2018 · 0 comments

Comments

@hswick
Copy link
Contributor

hswick commented Dec 17, 2018

Now that we have the jackpot there and the rate is at around 50%, it seems to be consistently disrupting the tests.

I've added a test for the jackpot in the unit tests, so we can be certain the logic is correct when deploying in production. I'm thinking what we need now is to deploy and use a dummy jackpot manager like we had in the old incentive-layer repo.

We can differentiate which one to use at runtime with the production one being deployed like so:

NODE_ENV='production' npm run deploy

Work items:

  1. Move forced error algo to jackpot manager
  2. Create dummy jackpot manager
  3. Integrate dummy jackpot manager into incentive layer contract
  4. Create condition in deploy.js to deploy production jackpot manager when prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant