-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPress 5.3 compatibility #18
Comments
Any ETA on this? I just tried to install the plug in on a client's WP 5.3.2 install and it failed with: |
hi @jameshome - The current version is working with 5.3.2. I just need to check a few things before resolving/closing this issue. Did you download this version https://wordpress.org/plugins/ghost/ ? |
Actually, I have the plugin installed in version 5.3.2, and when I click on the "zip" or "json" links, I get presented with a white screen, and nothing else happens. Is there any plugin that could collide with this one? |
@nuclearpengy thanks for the quick response and sorry I entirely missed it until now! I did indeed try to install that version. I tried several times and had no luck. I moved on to another part of the project and promptly forgot all about it until Friday, when I tried again and it installed just fine. Yay! Unfortunately, it would neither give me the zip or json files, instead erroring with a Wordpress fatal. Boo. I don't presently have access to the Wordpress debug logs, so your guess is better than mine what the problem is, but that seems like it's my problem to deal with and unlikely to be a plug-in bug. Thanks again! |
@jameshome hi, for some reason it worked. The changes I made were to activate php 7.4, and disable 7.3. For some reason, the zip file just worked as expected, |
Refs #18 - Removes calls for Open Sans webfont - Removes many custom styles, opting to use WP defaults - Fixes Ghost icon display - Updates screenshot
WordPress 5.3 is scheduled to be released on 12 November 2019. Test the plugin with WordPress 5.3 and ensure it's compatible.
Areas to focus on:
WP_MS_Sites_List_Table
class: https://make.wordpress.org/core/2019/10/15/enhancements-to-the-network-sites-screen-in-wordpress-5-3/.wp_die()
: https://make.wordpress.org/core/2019/10/15/changes-to-wp_die-html-output-in-wordpress-5-3/.The text was updated successfully, but these errors were encountered: