Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a bleeding edge release (11.x-dev at the moment) #8

Open
penyaskito opened this issue Apr 27, 2024 · 2 comments
Open

Provide a bleeding edge release (11.x-dev at the moment) #8

penyaskito opened this issue Apr 27, 2024 · 2 comments

Comments

@penyaskito
Copy link
Contributor

Even if not tagged, providing a version for 11.x could be useful. Soon people might want to test against 11.x HEAD before release.

I wanted to give it a try, so looking at the Makefile and playing with jq ended up with:

curl --silent https://api.github.com/repos/drupal/recommended-project/tags | jq '.|= . +[{"name":"11.x@dev"}]' | jq -r '.[].name'

Then I noticed I would need to skip this one for not marking it as latest, etc, etc, and ended up just trying:

docker build --build-arg DRUPAL_VERSION=11.x@dev --build-arg PHP_VERSION=8.3 -t q0rban/tugboat-drupal:11.x .

and it worked!

So maybe this should just be an adhoc target?

The only piece missing is that if DRUPAL_VERSION = 11.x, we should require drush/drush:13.x-dev in Dockerfile.

Is this a good idea? Even if being a moving target, don't think people would expect 11.x image to be stable.

@q0rban
Copy link
Collaborator

q0rban commented Apr 27, 2024

Very smart, @penyaskito !

Hmm, I'd really rather wait until we have an alpha tagged, as otherwise we risk builds failing on this project. But if you want to work on a draft PR, and it doesn't add too much complexity to things, I would consider it!

The only piece missing is that if DRUPAL_VERSION = 11.x, we should require drush/drush:13.x-dev in Dockerfile.

Hmm, it works with just composer require drush/drush inside of https://github.com/TugboatQA/drupalorg/blob/master/drupal/11.x/config.yml#L25. Is it because recommended-project sets prefer-stable to true?

@penyaskito penyaskito changed the title Provide 11.x Provide a bleeding edge release (11.x-dev at the moment) Apr 27, 2024
@penyaskito
Copy link
Contributor Author

Hmm, it works with just composer require drush/drush inside of TugboatQA/drupalorg@master/drupal/11.x/config.yml#L25. Is it because recommended-project sets prefer-stable to true?

I think so, but might not even be required. I'm just used to specify drush versions. We should test without a specific version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants