Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up __getstate__ and __setstate__ and add serialization tests #64

Open
lmcinnes opened this issue Jun 15, 2021 · 2 comments
Open

Set up __getstate__ and __setstate__ and add serialization tests #64

lmcinnes opened this issue Jun 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@lmcinnes
Copy link
Contributor

Most things should just pickle, however numba based attributes (functions and types such as numba.typed.List) need special handling with __getstate__ and __setstate__ methods to handle conversion of numba bits and pieces.

To aid in this we should have tests that all classes can be pickled and unpickled successfully. This will help highlight any shortcomings.

See also #62

@lmcinnes lmcinnes added the enhancement New feature or request label Jun 15, 2021
@cakiki
Copy link
Contributor

cakiki commented Nov 23, 2024

What exactly would this entail? I could have a look

@lmcinnes
Copy link
Contributor Author

MOstly it just means converting any numba things to python things in __set_state__ and vice versa in __get_state__. We would be delighted if you wanted to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants