From 682eff7a02c785b1d1a62dad99d08b79f0bb9313 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Ba=C3=B1ados=20Schwerter?= Date: Sat, 15 Jun 2024 00:56:15 +0000 Subject: [PATCH] Test upgrade suggestions --- src/CreeDictionary/API/search/test_espt_crk.py | 2 +- src/CreeDictionary/CreeDictionary/test_views.py | 2 +- src/CreeDictionary/tests/API_tests/model_test.py | 1 + src/CreeDictionary/tests/test_fst_regressions.py | 2 +- src/crkeng/app/integration_tests/test_paradigm_manager.py | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/CreeDictionary/API/search/test_espt_crk.py b/src/CreeDictionary/API/search/test_espt_crk.py index 8948af25e..9cfc79b3b 100644 --- a/src/CreeDictionary/API/search/test_espt_crk.py +++ b/src/CreeDictionary/API/search/test_espt_crk.py @@ -49,7 +49,7 @@ def test_search_with_tags(query, has_tags, tags, filtered_query): "expected_query_terms": ["cat"], "expected_new_tags": ["+N", "+Px1Sg", "+Pl"], "slug": "minôs", - "expected_inflection": "niminôsak", + "expected_inflection": "niminôsimak", }, ], [ diff --git a/src/CreeDictionary/CreeDictionary/test_views.py b/src/CreeDictionary/CreeDictionary/test_views.py index 5a775c916..6a515078a 100644 --- a/src/CreeDictionary/CreeDictionary/test_views.py +++ b/src/CreeDictionary/CreeDictionary/test_views.py @@ -99,7 +99,7 @@ def test_pages_render_without_template_errors(url: str, client: Client, caplog): [ ("niya", None, ["niyanân", "kiyânaw", "kiyawâw", "wiyawâw"]), ("awa", "awa@pra", ["ôma", "awa", "ana"]), - ("minôs", None, ["minôs", "minôsa", "niminôs"]), + ("minôs", None, ["minôs", "minôsa", "niminôsim"]), ], ) def test_retrieve_paradigm( diff --git a/src/CreeDictionary/tests/API_tests/model_test.py b/src/CreeDictionary/tests/API_tests/model_test.py index 07366bfd9..9b6176749 100644 --- a/src/CreeDictionary/tests/API_tests/model_test.py +++ b/src/CreeDictionary/tests/API_tests/model_test.py @@ -323,6 +323,7 @@ def test_search_results_order(query: str, top_result: str, later_result: str): ), f"{top_result} did not come before {later_result}" +@pytest.mark.skip(reason="New FSTs do not fail on this situation. Note this skip may reintroduce regressions. If that happens we'll get a replacement test case.") @pytest.mark.django_db def test_logs_error_on_analyzable_result_without_generated_string(caplog): """ diff --git a/src/CreeDictionary/tests/test_fst_regressions.py b/src/CreeDictionary/tests/test_fst_regressions.py index 8fd4d543b..e2d14f01c 100644 --- a/src/CreeDictionary/tests/test_fst_regressions.py +++ b/src/CreeDictionary/tests/test_fst_regressions.py @@ -16,7 +16,7 @@ # See: https://github.com/UAlbertaALTLab/morphodict/issues/897 "ê-pim-nêhiyawêyahk", RichAnalysis( - (("PV/e+", "PV/pimi+"), "nêhiyawêw", ("+V", "+AI", "+Cnj", "+12Pl")) + (("PV/e+", "PV/pimi+"), "nêhiýawêw", ("+V", "+AI", "+Cnj", "+12Pl")) ), ), ( diff --git a/src/crkeng/app/integration_tests/test_paradigm_manager.py b/src/crkeng/app/integration_tests/test_paradigm_manager.py index e58e88491..696eef459 100644 --- a/src/crkeng/app/integration_tests/test_paradigm_manager.py +++ b/src/crkeng/app/integration_tests/test_paradigm_manager.py @@ -69,7 +69,7 @@ def test_generates_na_paradigm(paradigm_manager) -> None: """ lemma = "minôs" word_class = "NA" - inflections = ["minôsa", "minôsak", "niminôs"] + inflections = ["minôsa", "minôsak", "niminôsim"] default_size = first(paradigm_manager.sizes_of(word_class)) paradigm = paradigm_manager.paradigm_for(word_class, lemma=lemma, size=default_size)