root inconsistency between master and rel_6.2.0

[danieldeidda]

Not sure if an issue is the right thing to do. But I have noticed a recurrent error when I use master when installing STIR with our mediso extension. In particular I get the following error:
/home/nmdicom-recon/devel/gitlab_copies/stir-mediso-extension/src/include/Mediso/spect/MedisoListModeToROOT.h:15:10: fatal error: TFile.h: No such file or directory
15 | #include "TFile.h"

And I don't get this error when installing rel6.2.0 (which is the only thing I changed)
was there any change that could be causing this or should I look for the error somewhere else?

[KrisThielemans]

I did recently make some effort to avoid "spoiling" the include path, #1536. There's another one coming up #1518. This means that it might be that the ROOT include path was added to all files, but not anymore.

So, I think you'll need explicit lines like

STIR/src/IO/CMakeLists.txt

Lines 84 to 89 in 2eb11a9

	target_include_directories(IO PRIVATE ${CERN_ROOT_INCLUDE_DIRS})
	if (TARGET ROOT::Tree)
	target_link_libraries(IO PRIVATE ROOT::Tree)
	else()
	target_link_libraries(IO PRIVATE ${CERN_ROOT_LIBRARIES})
	endif()

[danieldeidda]

so I would need something like that for every folder that uses root?

[KrisThielemans]

If you use a dependency of STIR, as opposed to STIR itself, you will have to make that explicit in the CMakeLists.txt, yes.

If you have an underlying library that uses ROOT, then you will need to add it there only.

[KrisThielemans]

@danieldeidda can this be closed? Maybe we should add a line to the release notes about it first.