Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

88 flipped hitc #89

Merged
merged 3 commits into from
Jul 10, 2024
Merged

88 flipped hitc #89

merged 3 commits into from
Jul 10, 2024

Conversation

brown-jason
Copy link
Collaborator

Cutoff now takes into sign(top) into account.

@brown-jason brown-jason marked this pull request as draft June 10, 2024 19:08
@madison-feshuk
Copy link
Collaborator

madison-feshuk commented Jun 10, 2024

See https://github.com/USEPA/ToxCast-Internal/tree/main/analysis/tcplfit2_hitc_toplikelihood
for a standalone analysis reviewing this issue and fix (Rmd and html). Slides featuring the reprocessing results on the ToxCast database, which were presented to HTTr/HTPP/ToxCast teams on 6/10, are also provided.

ToxCast team approves this toplikelihood fix for its invitrodb v4.2 release. In the release note, an known issue will be listed related to poly2 reparameterization which may be skewing toplikelihood calculation #90

Copy link
Collaborator

@leverett-epa leverett-epa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense for my understanding of the issue, and testing appears to have demonstrated the validity of this approach

@brown-jason brown-jason merged commit 63a48de into dev Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants