Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagger tag adjustment API enhancements #69

Open
davenquinn opened this issue Mar 25, 2021 · 1 comment
Open

Tagger tag adjustment API enhancements #69

davenquinn opened this issue Mar 25, 2021 · 1 comment
Assignees
Labels
bug Something isn't working stale tagger

Comments

@davenquinn
Copy link
Contributor

Right now, POSTing new tags to the tagger API accepts a single tagger parameter alongside a list of tags. This makes sense for new tag additions, where we want to ensure that tags all have the right user created.

However this API route fails when we are adjusting already-saved tags. When we pass a different tagger than the tag was initially saved by, we end up creating duplicates. In PR #65, we solve this using a frontend hack of setting the tagger parameter to the value returned for the first tag. This works fine, but only if all tags were created by the same user.

I propose that the tagger app API be modified to optionally accept a tagger, ignore the tagger parameter provided if it conflicts with a previous value, or to simply overwrite the old tag with the new one tied to the new tagger. Either way, we shouldn't duplicate tags on edit.

I don't actually know where that code lives now, so i can't make this a PR in the correct place.

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale tagger
Projects
None yet
Development

No branches or pull requests

2 participants