From 38050cb1e710625fdfd125c5bf415e0966deaaba Mon Sep 17 00:00:00 2001 From: Thomas Rahm <67757218+ThomasRahm@users.noreply.github.com> Date: Fri, 3 May 2024 02:54:56 +0200 Subject: [PATCH] Fix guaranteed line below large cradle base. --- src/TreeSupport.cpp | 8 ++++---- src/TreeSupportCradle.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/TreeSupport.cpp b/src/TreeSupport.cpp index 1f4fbc2530..c67f8efe22 100644 --- a/src/TreeSupport.cpp +++ b/src/TreeSupport.cpp @@ -2602,16 +2602,16 @@ void TreeSupport::generateSupportSkin( } Polygons cradle_lines_roof = cradle_support_line_roof_areas[layer_idx].unionPolygons(); Polygons remove_from_next_roof = storage.support.supportLayers[layer_idx].getTotalAreaFromParts(storage.support.supportLayers[layer_idx].support_roof).unionPolygons(); + if (! support_free_areas[layer_idx].empty()) + { + remove_from_next_roof.add(support_free_areas[layer_idx]); + } //Remove only already added roof from line areas. Should not be needed, but better safe than sorry. cradle_lines_roof = cradle_lines_roof.difference(remove_from_next_roof); cradle_support_line_areas[layer_idx] = cradle_support_line_areas[layer_idx].unionPolygons().difference(remove_from_next_roof); //Collect remaining parts that non cradle line roof areas may not intersect with. remove_from_next_roof.add(cradle_line_xy_distance_areas[layer_idx]); - if (! support_free_areas[layer_idx].empty()) - { - remove_from_next_roof.add(support_free_areas[layer_idx]); - } remove_from_next_roof = remove_from_next_roof.unionPolygons(); Polygons remove_from_next_fractional_roof = remove_from_next_roof; diff --git a/src/TreeSupportCradle.cpp b/src/TreeSupportCradle.cpp index 595147b441..5feb9ea519 100644 --- a/src/TreeSupportCradle.cpp +++ b/src/TreeSupportCradle.cpp @@ -1226,7 +1226,7 @@ void SupportCradleGeneration::pushCradleData(std::vector