Cura 11821 crash due to permission #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writing debug.html in the current folder (in case of build the program data) makes it read only and no write modifications are allowed, hence crash. Now it is written in temp foilder of the computer where writing the file is also allowed.
Also this code contains svg generation, which is majorly used in debugging application
jellespijker
requested changes
Apr 27, 2024
There was a problem hiding this comment.
@saumyaj3 I think the question you need to ask is why does it even tries to execute the code surrounded by the DEBUG guards, while the error happens on production.
It might be that this happens because the releases are now build with RelWithDebug, I'm not sure but you need to double check this, because now it feels like you are patching up a symptom and not the root-cause.
If it is indeed happening due to an added DEBUG preprocessor flag while building Cura for production. It could also explain this Sentry issue: https://ultimaker-o7.sentry.io/issues/5077178563/
casperlamboo
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
writing debug.html in temp folder
writing debug.html in the current folder (in case of build the program data) makes it read only and no write modifications are allowed, hence crash. Now it is written in temp folder of the computer where writing the file is also allowed.
should solve : Ultimaker/Cura#18835
CURA-11821