Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cura 12275 retract before outer wall only works on the initial layer #2172

Conversation

wawanbreton
Copy link
Contributor

The travel_retract_before_outer_wall setting is settable per-mesh, but the global value was previously taken in this context. We now take the value of the setting, for the mesh we are moving to.

CURA-12275
Fixes Ultimaker/Cura#19876

wawanbreton and others added 2 commits November 11, 2024 13:16
CURA-12275
The travel_retract_before_outer_wall setting is settable per-mesh, but the global value was previously taken in this context. We now take the value of the setting, for the mesh we are moving to.
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good -- though I know the code won't reach there, it still feels a little risky to return nullptr like that and not check... 😆

@HellAholic HellAholic merged commit d9a2afc into 5.9 Nov 12, 2024
27 checks passed
@HellAholic HellAholic deleted the CURA-12275_retract-before-outer-wall-only-works-on-the-initial-layer branch November 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants