Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFDL MOM6 model aborts with netcdf-fortran-4.6.0. Works with netcdf-fortran-4.5.3. (SUSPECT MOM6 ISSUE BUT OPENING AT REQUEST OF NETCDF SUPPORT) #395

Open
GeorgeVandenberghe-NOAA opened this issue Mar 27, 2023 · 22 comments
Assignees
Milestone

Comments

@GeorgeVandenberghe-NOAA
Copy link

GeorgeVandenberghe-NOAA commented Mar 27, 2023

The GFDL MOM6 ocean model fails with a field name error when using netcdf-fortran-4.6.0. It runs normally with netcdf-fortran-4.5.3. I strongly suspect this is not a NetCDF issue but am submitting this issue at the request of NetCDF support. Will try to replicate this when I get a chance on gaea C5 and report the error message which has been lost on C5. The rest of the software is netcdf-c-4.7.4 (also fails with 4.9.1) and hdf5/1.12.2.

@GeorgeVandenberghe-NOAA
Copy link
Author

The error message from MOM6
8416: FATAL from PE 0: NetCDF: Name contains illegal characters: netcdf_add_variable: file:MOM6_OUTPUT/ocean_geometry.ncvariable:lath

A second came from the ATM model after 24 hours in an ATM only run
0: FATAL from PE 0: NetCDF: Name contains illegal characters: netcdf_add_variable: file:RESTART/20200602.060000.fv_core.res.ncvariable:xaxis_1

I will report these to EMC.

@WardF
Copy link
Member

WardF commented Mar 27, 2023

Thank you!

@WardF WardF added this to the Future milestone Mar 27, 2023
@WardF WardF self-assigned this Mar 27, 2023
@WardF WardF modified the milestones: Future, 4.6.1 Mar 27, 2023
@edwardhartnett
Copy link
Contributor

What are the illegal names being attempted?

That is, what is the software trying to use for a variable name?

@GeorgeVandenberghe-NOAA
Copy link
Author

@edwardhartnett
Copy link
Contributor

Is a '*' valid in a variable name in netCDF?

@GeorgeVandenberghe-NOAA
Copy link
Author

GeorgeVandenberghe-NOAA commented Mar 29, 2023 via email

@edwardhartnett
Copy link
Contributor

According to this answer, asterisks should be allowed in names: https://www.unidata.ucar.edu/support/help/MailArchives/netcdf/msg10684.html

@DennisHeimbigner
Copy link
Collaborator

I believe that is correct.

@edwardhartnett
Copy link
Contributor

Oh, duh, it's right there in front of us:

Name contains illegal characters:
   netcdf_add_variable: file:RESTART/20200602.060000.fv_core.res.ncvariable
   *:xaxis_1*

There's a "/" there. Is that part of the variable name? Because that it an illegal character for netCDF names, IIRC...

@GeorgeVandenberghe-NOAA
Copy link
Author

@GeorgeVandenberghe-NOAA
Copy link
Author

I can start looking at this after I get the benchmark off my desk and out the door.

@edwardhartnett
Copy link
Contributor

Maybe the variable is named "file:RESTART/20200602.060000.fv_core.res.ncvariable :xaxis_1"? Can you ask the programmers?

Surely at some point this must have worked, yet as far as I know there has been no change in illegal name characters since @DennisHeimbigner changed everything to allow unicode, and that was like 15 years ago. Dennis have there been changes to what's legal in a name since then?

@GeorgeVandenberghe-NOAA
Copy link
Author

@DennisHeimbigner
Copy link
Collaborator

There have been no changes as far as I know. But it is still the case that the '/' character is not legal.

@bensonr
Copy link

bensonr commented Mar 29, 2023

GFDL models are running just fine with the cray-netcdf modules on the Gaea C5 partition. The versions appear to be C-4.9.0 and Fortran-4.5.3 (according to nc- and nf-config). I have asked an FMS engineer to run unit tests on an internal system at GFDL with C-4.9.0 and Fortran-4.6.0.

@GeorgeVandenberghe-NOAA
Copy link
Author

@uramirez8707
Copy link

Maybe the variable is named "file:RESTART/20200602.060000.fv_core.res.ncvariable :xaxis_1"? Can you ask the programmers?

The filename is "RESTART/20200602.060000.fv_core.res.nc"
and the variable name is "xaxis_1"

Something like this should be the traceback
https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/blob/cfae631cb9c07b40863441c157a39787626ba1fc/tools/fv_io.F90#L131
https://github.com/NOAA-GFDL/FMS/blob/7188e3a2e634376da74c3e4247bc9b487ef52700/fms2_io/fms_netcdf_domain_io.F90#L548
https://github.com/NOAA-GFDL/FMS/blob/7188e3a2e634376da74c3e4247bc9b487ef52700/fms2_io/netcdf_io.F90#L956-L964

@GeorgeVandenberghe-NOAA
Copy link
Author

@bensonr
Copy link

bensonr commented Mar 30, 2023

@GeorgeVandenberghe-NOAA - I'll ask again, what compiler (assuming Intel - ifx? ifort?) and version (19, OneAPI 2022, ??) are you using?

@GeorgeVandenberghe-NOAA
Copy link
Author

@GeorgeVandenberghe-NOAA
Copy link
Author

@GeorgeVandenberghe-NOAA
Copy link
Author

@WardF WardF modified the milestones: 4.6.1, 4.6.2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants