Fix s3 ncml #1277
Merged
Fix s3 ncml #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
fix-s3-ncml
branch
from
b4e3cc5 to
aa7a526
Compare
haileyajohnson
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes reading ncml files stored on S3 (Resolves #1231). This requires fixing logic used by the NcmlReader to use
MFiles instead ofFiles andURLs. Unfortunately it also requires several special cases, checking forcdms3protocols-- this isn't the nicest but I am not seeing another way to fix this without refactoring all this code.Add unit tests to test the
DatasetURLcode. Integration tests will be added to the TDS (Unidata/tds#438)Jenkins tests passing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/40/