Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix nested reverts #102

Closed
saucepoint opened this issue Mar 15, 2024 · 1 comment
Closed

[Bug]: Fix nested reverts #102

saucepoint opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@saucepoint
Copy link
Collaborator

Describe the bug

In Quoter, there's a nested revert that's not bubbling up correctly

Expected Behavior

The earliest revert should bubble up

To Reproduce

No response

Additional context

#100 (comment)
@saucepoint saucepoint added the bug Something isn't working label Mar 15, 2024
@nishim3
Copy link

nishim3 commented Mar 18, 2024

image
The sender and the manager have the same address, so the revert InvalidLockAcquiredSender(); line is not reached through the tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saucepoint @nishim3