Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Need to Support for the Latest v4-core Version #99

Closed
skywalker2017 opened this issue Mar 1, 2024 · 2 comments
Closed

[Bug]: Need to Support for the Latest v4-core Version #99

skywalker2017 opened this issue Mar 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@skywalker2017
Copy link

Describe the bug

address has been deleted in lockAcquired function
image

Expected Behavior

test cases should be updated to adapt to this modification

To Reproduce

No response

Additional context

No response

@skywalker2017 skywalker2017 added the bug Something isn't working label Mar 1, 2024
@saucepoint
Copy link
Collaborator

hey thanks for flagging -- lots of changes happening to core soon, so we might wait for some more breaking changes and then do another big resync

if your project is using v4-core and v4-periphery, there's two options to avoid the incompatibility

  1. remove the top-level v4-core dependency, and access v4-core through v4-periphery's child dependency
  2. Fork BaseHook with the corrected ILockCallback signatures

@saucepoint
Copy link
Collaborator

closed here #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants