From ec11bfa231a2e2236bc61b50437a5d8afb9d8260 Mon Sep 17 00:00:00 2001 From: Abdulla Al-Kamil Date: Thu, 12 Dec 2024 11:40:06 +0000 Subject: [PATCH 1/8] feat: add scoping to _increaseFromDeltas --- src/PositionManager.sol | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/PositionManager.sol b/src/PositionManager.sol index be718d4d..9c08f3af 100644 --- a/src/PositionManager.sol +++ b/src/PositionManager.sol @@ -309,16 +309,19 @@ contract PositionManager is { (PoolKey memory poolKey, PositionInfo info) = getPoolAndPositionInfo(tokenId); - (uint160 sqrtPriceX96,,,) = poolManager.getSlot0(poolKey.toId()); - - // Use the credit on the pool manager as the amounts for the mint. - uint256 liquidity = LiquidityAmounts.getLiquidityForAmounts( - sqrtPriceX96, - TickMath.getSqrtPriceAtTick(info.tickLower()), - TickMath.getSqrtPriceAtTick(info.tickUpper()), - _getFullCredit(poolKey.currency0), - _getFullCredit(poolKey.currency1) - ); + uint256 liquidity; + { + (uint160 sqrtPriceX96,,,) = poolManager.getSlot0(poolKey.toId()); + + // Use the credit on the pool manager as the amounts for the mint. + liquidity = LiquidityAmounts.getLiquidityForAmounts( + sqrtPriceX96, + TickMath.getSqrtPriceAtTick(info.tickLower()), + TickMath.getSqrtPriceAtTick(info.tickUpper()), + _getFullCredit(poolKey.currency0), + _getFullCredit(poolKey.currency1) + ); + } // Note: The tokenId is used as the salt for this position, so every minted position has unique storage in the pool manager. (BalanceDelta liquidityDelta, BalanceDelta feesAccrued) = From f2c471245203dfe6d05099a0c00518336e3a33fb Mon Sep 17 00:00:00 2001 From: Abdulla Al-Kamil Date: Thu, 12 Dec 2024 11:41:38 +0000 Subject: [PATCH 2/8] feat: assign params to memory in _burn --- src/PositionManager.sol | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/PositionManager.sol b/src/PositionManager.sol index 9c08f3af..291f86f2 100644 --- a/src/PositionManager.sol +++ b/src/PositionManager.sol @@ -426,16 +426,13 @@ contract PositionManager is if (liquidity > 0) { BalanceDelta liquidityDelta; // do not use _modifyLiquidity as we do not need to notify on modification for burns. - (liquidityDelta, feesAccrued) = poolManager.modifyLiquidity( - poolKey, - IPoolManager.ModifyLiquidityParams({ - tickLower: info.tickLower(), - tickUpper: info.tickUpper(), - liquidityDelta: -(liquidity.toInt256()), - salt: bytes32(tokenId) - }), - hookData - ); + IPoolManager.ModifyLiquidityParams memory params = IPoolManager.ModifyLiquidityParams({ + tickLower: info.tickLower(), + tickUpper: info.tickUpper(), + liquidityDelta: -(liquidity.toInt256()), + salt: bytes32(tokenId) + }); + (liquidityDelta, feesAccrued) = poolManager.modifyLiquidity(poolKey, params, hookData); // Slippage checks should be done on the principal liquidityDelta which is the liquidityDelta - feesAccrued (liquidityDelta - feesAccrued).validateMinOut(amount0Min, amount1Min); } From bd1394dbd925de9f4c1b5b1b296a5282b8234f87 Mon Sep 17 00:00:00 2001 From: Abdulla Al-Kamil Date: Thu, 12 Dec 2024 13:23:48 +0000 Subject: [PATCH 3/8] feat: dont compile posm with ir --- foundry.toml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/foundry.toml b/foundry.toml index 55eaaa17..67315fa0 100644 --- a/foundry.toml +++ b/foundry.toml @@ -2,7 +2,7 @@ out = 'foundry-out' solc_version = '0.8.26' optimizer_runs = 44444444 -via_ir = true +via_ir = false ffi = true fs_permissions = [{ access = "read-write", path = ".forge-snapshots/" }, { access = "read", path = "foundry-out/" }] evm_version = "cancun" @@ -11,13 +11,11 @@ fuzz_runs = 10_000 bytecode_hash = "none" additional_compiler_profiles = [ - { name = "posm", via_ir = true, optimizer_runs = 30000 }, { name = "descriptor", via_ir = true, optimizer_runs = 1 }, { name = "test", via_ir = false } ] compilation_restrictions = [ - { paths = "src/PositionManager.sol", optimizer_runs = 30000 }, { paths = "src/PositionDescriptor.sol", optimizer_runs = 1 }, { paths = "test/**", via_ir = false } ] From f05bfaab49301b425e2bdbe8b5713006c66123d6 Mon Sep 17 00:00:00 2001 From: Abdulla Al-Kamil Date: Thu, 12 Dec 2024 13:23:58 +0000 Subject: [PATCH 4/8] chore: gas --- snapshots/PosMGasTest.json | 80 ++++++++++++++++++------------------ snapshots/QuoterTest.json | 26 ++++++------ snapshots/StateViewTest.json | 20 ++++----- 3 files changed, 63 insertions(+), 63 deletions(-) diff --git a/snapshots/PosMGasTest.json b/snapshots/PosMGasTest.json index 195b2104..e379c37f 100644 --- a/snapshots/PosMGasTest.json +++ b/snapshots/PosMGasTest.json @@ -1,42 +1,42 @@ { - "PositionManager_burn_empty": "51102", - "PositionManager_burn_empty_native": "51102", - "PositionManager_burn_nonEmpty_native_withClose": "127695", - "PositionManager_burn_nonEmpty_native_withTakePair": "127137", - "PositionManager_burn_nonEmpty_withClose": "134600", - "PositionManager_burn_nonEmpty_withTakePair": "134043", - "PositionManager_collect_native": "147732", - "PositionManager_collect_sameRange": "156364", - "PositionManager_collect_withClose": "156364", - "PositionManager_collect_withTakePair": "155679", - "PositionManager_decreaseLiquidity_native": "113681", - "PositionManager_decreaseLiquidity_withClose": "121933", - "PositionManager_decreaseLiquidity_withTakePair": "121248", - "PositionManager_decrease_burnEmpty": "137500", - "PositionManager_decrease_burnEmpty_native": "130595", - "PositionManager_decrease_sameRange_allLiquidity": "134649", - "PositionManager_decrease_take_take": "122490", - "PositionManager_increaseLiquidity_erc20_withClose": "160652", - "PositionManager_increaseLiquidity_erc20_withSettlePair": "159563", - "PositionManager_increaseLiquidity_native": "143532", - "PositionManager_increase_autocompoundExactUnclaimedFees": "138231", - "PositionManager_increase_autocompoundExcessFeesCredit": "179593", - "PositionManager_increase_autocompound_clearExcess": "149511", - "PositionManager_mint_native": "367550", - "PositionManager_mint_nativeWithSweep_withClose": "376153", - "PositionManager_mint_nativeWithSweep_withSettlePair": "375348", - "PositionManager_mint_onSameTickLower": "319298", - "PositionManager_mint_onSameTickUpper": "319940", - "PositionManager_mint_sameRange": "245522", - "PositionManager_mint_settleWithBalance_sweep": "420760", - "PositionManager_mint_warmedPool_differentRange": "325316", - "PositionManager_mint_withClose": "421910", - "PositionManager_mint_withSettlePair": "420939", - "PositionManager_multicall_initialize_mint": "458237", - "PositionManager_permit": "79175", - "PositionManager_permit_secondPosition": "62063", - "PositionManager_permit_twice": "44975", - "PositionManager_subscribe": "87968", - "PositionManager_unsubscribe": "62697", - "positionManager bytecode size": "23877" + "PositionManager_burn_empty": "50328", + "PositionManager_burn_empty_native": "50328", + "PositionManager_burn_nonEmpty_native_withClose": "126829", + "PositionManager_burn_nonEmpty_native_withTakePair": "126230", + "PositionManager_burn_nonEmpty_withClose": "133735", + "PositionManager_burn_nonEmpty_withTakePair": "133136", + "PositionManager_collect_native": "146902", + "PositionManager_collect_sameRange": "155534", + "PositionManager_collect_withClose": "155534", + "PositionManager_collect_withTakePair": "154797", + "PositionManager_decreaseLiquidity_native": "113017", + "PositionManager_decreaseLiquidity_withClose": "121103", + "PositionManager_decreaseLiquidity_withTakePair": "120366", + "PositionManager_decrease_burnEmpty": "136701", + "PositionManager_decrease_burnEmpty_native": "129796", + "PositionManager_decrease_sameRange_allLiquidity": "133819", + "PositionManager_decrease_take_take": "121750", + "PositionManager_increaseLiquidity_erc20_withClose": "159357", + "PositionManager_increaseLiquidity_erc20_withSettlePair": "158218", + "PositionManager_increaseLiquidity_native": "142406", + "PositionManager_increase_autocompoundExactUnclaimedFees": "137480", + "PositionManager_increase_autocompoundExcessFeesCredit": "178784", + "PositionManager_increase_autocompound_clearExcess": "148698", + "PositionManager_mint_native": "366514", + "PositionManager_mint_nativeWithSweep_withClose": "375221", + "PositionManager_mint_nativeWithSweep_withSettlePair": "374358", + "PositionManager_mint_onSameTickLower": "318141", + "PositionManager_mint_onSameTickUpper": "318783", + "PositionManager_mint_sameRange": "244365", + "PositionManager_mint_settleWithBalance_sweep": "419937", + "PositionManager_mint_warmedPool_differentRange": "324159", + "PositionManager_mint_withClose": "420705", + "PositionManager_mint_withSettlePair": "419680", + "PositionManager_multicall_initialize_mint": "455655", + "PositionManager_permit": "79458", + "PositionManager_permit_secondPosition": "62370", + "PositionManager_permit_twice": "45270", + "PositionManager_subscribe": "87808", + "PositionManager_unsubscribe": "61956", + "positionManager bytecode size": "28169" } \ No newline at end of file diff --git a/snapshots/QuoterTest.json b/snapshots/QuoterTest.json index a3c80a4f..608ef8b1 100644 --- a/snapshots/QuoterTest.json +++ b/snapshots/QuoterTest.json @@ -1,15 +1,15 @@ { - "Quoter_exactInputSingle_oneForZero_multiplePositions": "145902", - "Quoter_exactInputSingle_zeroForOne_multiplePositions": "152117", - "Quoter_exactOutputSingle_oneForZero": "79267", - "Quoter_exactOutputSingle_zeroForOne": "84512", - "Quoter_quoteExactInput_oneHop_1TickLoaded": "122728", - "Quoter_quoteExactInput_oneHop_initializedAfter": "147363", - "Quoter_quoteExactInput_oneHop_startingInitialized": "80638", - "Quoter_quoteExactInput_twoHops": "204942", - "Quoter_quoteExactOutput_oneHop_1TickLoaded": "122224", - "Quoter_quoteExactOutput_oneHop_2TicksLoaded": "152879", - "Quoter_quoteExactOutput_oneHop_initializedAfter": "122251", - "Quoter_quoteExactOutput_oneHop_startingInitialized": "98545", - "Quoter_quoteExactOutput_twoHops": "204670" + "Quoter_exactInputSingle_oneForZero_multiplePositions": "146722", + "Quoter_exactInputSingle_zeroForOne_multiplePositions": "152948", + "Quoter_exactOutputSingle_oneForZero": "80318", + "Quoter_exactOutputSingle_zeroForOne": "85565", + "Quoter_quoteExactInput_oneHop_1TickLoaded": "123940", + "Quoter_quoteExactInput_oneHop_initializedAfter": "148554", + "Quoter_quoteExactInput_oneHop_startingInitialized": "81829", + "Quoter_quoteExactInput_twoHops": "206923", + "Quoter_quoteExactOutput_oneHop_1TickLoaded": "123618", + "Quoter_quoteExactOutput_oneHop_2TicksLoaded": "154273", + "Quoter_quoteExactOutput_oneHop_initializedAfter": "123645", + "Quoter_quoteExactOutput_oneHop_startingInitialized": "99939", + "Quoter_quoteExactOutput_twoHops": "206951" } \ No newline at end of file diff --git a/snapshots/StateViewTest.json b/snapshots/StateViewTest.json index dc141e39..93105c96 100644 --- a/snapshots/StateViewTest.json +++ b/snapshots/StateViewTest.json @@ -1,12 +1,12 @@ { - "StateView_extsload_getFeeGrowthGlobals": "2203", - "StateView_extsload_getFeeGrowthInside": "7875", - "StateView_extsload_getLiquidity": "1439", - "StateView_extsload_getPositionInfo": "2761", - "StateView_extsload_getPositionLiquidity": "1691", - "StateView_extsload_getSlot0": "1486", - "StateView_extsload_getTickBitmap": "1432", - "StateView_extsload_getTickFeeGrowthOutside": "2490", - "StateView_extsload_getTickInfo": "2693", - "StateView_extsload_getTickLiquidity": "1686" + "StateView_extsload_getFeeGrowthGlobals": "2376", + "StateView_extsload_getFeeGrowthInside": "8455", + "StateView_extsload_getLiquidity": "1487", + "StateView_extsload_getPositionInfo": "2905", + "StateView_extsload_getPositionLiquidity": "1724", + "StateView_extsload_getSlot0": "1584", + "StateView_extsload_getTickBitmap": "1682", + "StateView_extsload_getTickFeeGrowthOutside": "2734", + "StateView_extsload_getTickInfo": "3068", + "StateView_extsload_getTickLiquidity": "1879" } \ No newline at end of file From 3b04bd038674dc7f947299e1603f20010e8badae Mon Sep 17 00:00:00 2001 From: Abdulla Al-Kamil Date: Thu, 12 Dec 2024 13:49:37 +0000 Subject: [PATCH 5/8] feat: change optimizer runs to be below size limit --- foundry.toml | 4 +- snapshots/PosMGasTest.json | 80 +++++++++++++++++++------------------- 2 files changed, 43 insertions(+), 41 deletions(-) diff --git a/foundry.toml b/foundry.toml index 67315fa0..958c4060 100644 --- a/foundry.toml +++ b/foundry.toml @@ -11,12 +11,14 @@ fuzz_runs = 10_000 bytecode_hash = "none" additional_compiler_profiles = [ + { name = "posm", via_ir = false, optimizer_runs = 2000}, { name = "descriptor", via_ir = true, optimizer_runs = 1 }, { name = "test", via_ir = false } ] compilation_restrictions = [ - { paths = "src/PositionDescriptor.sol", optimizer_runs = 1 }, + { paths = "src/PositionManager.sol", via_ir = false, optimizer_runs = 2000}, + { paths = "src/PositionDescriptor.sol", via_ir = true, optimizer_runs = 1 }, { paths = "test/**", via_ir = false } ] diff --git a/snapshots/PosMGasTest.json b/snapshots/PosMGasTest.json index e379c37f..c74be856 100644 --- a/snapshots/PosMGasTest.json +++ b/snapshots/PosMGasTest.json @@ -1,42 +1,42 @@ { - "PositionManager_burn_empty": "50328", - "PositionManager_burn_empty_native": "50328", - "PositionManager_burn_nonEmpty_native_withClose": "126829", - "PositionManager_burn_nonEmpty_native_withTakePair": "126230", - "PositionManager_burn_nonEmpty_withClose": "133735", - "PositionManager_burn_nonEmpty_withTakePair": "133136", - "PositionManager_collect_native": "146902", - "PositionManager_collect_sameRange": "155534", - "PositionManager_collect_withClose": "155534", - "PositionManager_collect_withTakePair": "154797", - "PositionManager_decreaseLiquidity_native": "113017", - "PositionManager_decreaseLiquidity_withClose": "121103", - "PositionManager_decreaseLiquidity_withTakePair": "120366", - "PositionManager_decrease_burnEmpty": "136701", - "PositionManager_decrease_burnEmpty_native": "129796", - "PositionManager_decrease_sameRange_allLiquidity": "133819", - "PositionManager_decrease_take_take": "121750", - "PositionManager_increaseLiquidity_erc20_withClose": "159357", - "PositionManager_increaseLiquidity_erc20_withSettlePair": "158218", - "PositionManager_increaseLiquidity_native": "142406", - "PositionManager_increase_autocompoundExactUnclaimedFees": "137480", - "PositionManager_increase_autocompoundExcessFeesCredit": "178784", - "PositionManager_increase_autocompound_clearExcess": "148698", - "PositionManager_mint_native": "366514", - "PositionManager_mint_nativeWithSweep_withClose": "375221", - "PositionManager_mint_nativeWithSweep_withSettlePair": "374358", - "PositionManager_mint_onSameTickLower": "318141", - "PositionManager_mint_onSameTickUpper": "318783", - "PositionManager_mint_sameRange": "244365", - "PositionManager_mint_settleWithBalance_sweep": "419937", - "PositionManager_mint_warmedPool_differentRange": "324159", - "PositionManager_mint_withClose": "420705", - "PositionManager_mint_withSettlePair": "419680", - "PositionManager_multicall_initialize_mint": "455655", - "PositionManager_permit": "79458", - "PositionManager_permit_secondPosition": "62370", - "PositionManager_permit_twice": "45270", - "PositionManager_subscribe": "87808", - "PositionManager_unsubscribe": "61956", - "positionManager bytecode size": "28169" + "PositionManager_burn_empty": "50490", + "PositionManager_burn_empty_native": "50490", + "PositionManager_burn_nonEmpty_native_withClose": "127186", + "PositionManager_burn_nonEmpty_native_withTakePair": "126605", + "PositionManager_burn_nonEmpty_withClose": "134092", + "PositionManager_burn_nonEmpty_withTakePair": "133511", + "PositionManager_collect_native": "147259", + "PositionManager_collect_sameRange": "155891", + "PositionManager_collect_withClose": "155891", + "PositionManager_collect_withTakePair": "155177", + "PositionManager_decreaseLiquidity_native": "113303", + "PositionManager_decreaseLiquidity_withClose": "121460", + "PositionManager_decreaseLiquidity_withTakePair": "120746", + "PositionManager_decrease_burnEmpty": "137111", + "PositionManager_decrease_burnEmpty_native": "130205", + "PositionManager_decrease_sameRange_allLiquidity": "134176", + "PositionManager_decrease_take_take": "122135", + "PositionManager_increaseLiquidity_erc20_withClose": "159828", + "PositionManager_increaseLiquidity_erc20_withSettlePair": "158686", + "PositionManager_increaseLiquidity_native": "142853", + "PositionManager_increase_autocompoundExactUnclaimedFees": "137717", + "PositionManager_increase_autocompoundExcessFeesCredit": "179147", + "PositionManager_increase_autocompound_clearExcess": "149061", + "PositionManager_mint_native": "367155", + "PositionManager_mint_nativeWithSweep_withClose": "375927", + "PositionManager_mint_nativeWithSweep_withSettlePair": "375085", + "PositionManager_mint_onSameTickLower": "318686", + "PositionManager_mint_onSameTickUpper": "319328", + "PositionManager_mint_sameRange": "244910", + "PositionManager_mint_settleWithBalance_sweep": "420852", + "PositionManager_mint_warmedPool_differentRange": "324704", + "PositionManager_mint_withClose": "421370", + "PositionManager_mint_withSettlePair": "420354", + "PositionManager_multicall_initialize_mint": "456443", + "PositionManager_permit": "79572", + "PositionManager_permit_secondPosition": "62472", + "PositionManager_permit_twice": "45372", + "PositionManager_subscribe": "87949", + "PositionManager_unsubscribe": "62082", + "positionManager bytecode size": "23643" } \ No newline at end of file From 6e392c31edbbf53d0ed23543f57f732c8e740050 Mon Sep 17 00:00:00 2001 From: saucepoint Date: Wed, 18 Dec 2024 16:36:13 -0500 Subject: [PATCH 6/8] revert compilation changes --- foundry.toml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/foundry.toml b/foundry.toml index 958c4060..780d62c5 100644 --- a/foundry.toml +++ b/foundry.toml @@ -2,7 +2,7 @@ out = 'foundry-out' solc_version = '0.8.26' optimizer_runs = 44444444 -via_ir = false +via_ir = true ffi = true fs_permissions = [{ access = "read-write", path = ".forge-snapshots/" }, { access = "read", path = "foundry-out/" }] evm_version = "cancun" @@ -11,14 +11,14 @@ fuzz_runs = 10_000 bytecode_hash = "none" additional_compiler_profiles = [ - { name = "posm", via_ir = false, optimizer_runs = 2000}, + { name = "posm", via_ir = true, optimizer_runs = 30000 }, { name = "descriptor", via_ir = true, optimizer_runs = 1 }, { name = "test", via_ir = false } ] compilation_restrictions = [ - { paths = "src/PositionManager.sol", via_ir = false, optimizer_runs = 2000}, - { paths = "src/PositionDescriptor.sol", via_ir = true, optimizer_runs = 1 }, + { paths = "src/PositionManager.sol", optimizer_runs = 30000 }, + { paths = "src/PositionDescriptor.sol", optimizer_runs = 1 }, { paths = "test/**", via_ir = false } ] @@ -39,4 +39,4 @@ unichain_sepolia = "https://sepolia.unichain.org" base_sepolia = "https://sepolia.base.org" arbitrum_sepolia = "https://sepolia-rollup.arbitrum.io/rpc" -# See more config options https://github.com/foundry-rs/foundry/tree/master/config +# See more config options https://github.com/foundry-rs/foundry/tree/master/config \ No newline at end of file From ad280b3143d37582a870217c1d507427c1875847 Mon Sep 17 00:00:00 2001 From: saucepoint Date: Wed, 18 Dec 2024 16:40:03 -0500 Subject: [PATCH 7/8] regenerate snapshots with existing compilation parameters --- snapshots/PosMGasTest.json | 82 ++++++++++++++++++------------------ snapshots/QuoterTest.json | 26 ++++++------ snapshots/StateViewTest.json | 20 ++++----- 3 files changed, 64 insertions(+), 64 deletions(-) diff --git a/snapshots/PosMGasTest.json b/snapshots/PosMGasTest.json index bcead349..fab212ff 100644 --- a/snapshots/PosMGasTest.json +++ b/snapshots/PosMGasTest.json @@ -1,43 +1,43 @@ { - "PositionManager_burn_empty": "50490", - "PositionManager_burn_empty_native": "50490", - "PositionManager_burn_nonEmpty_native_withClose": "127186", - "PositionManager_burn_nonEmpty_native_withTakePair": "126605", - "PositionManager_burn_nonEmpty_withClose": "134092", - "PositionManager_burn_nonEmpty_withTakePair": "133511", - "PositionManager_collect_native": "147259", - "PositionManager_collect_sameRange": "155891", - "PositionManager_collect_withClose": "155891", - "PositionManager_collect_withTakePair": "155177", - "PositionManager_decreaseLiquidity_native": "113303", - "PositionManager_decreaseLiquidity_withClose": "121460", - "PositionManager_decreaseLiquidity_withTakePair": "120746", - "PositionManager_decrease_burnEmpty": "137111", - "PositionManager_decrease_burnEmpty_native": "130205", - "PositionManager_decrease_sameRange_allLiquidity": "134176", - "PositionManager_decrease_take_take": "122135", - "PositionManager_increaseLiquidity_erc20_withClose": "159828", - "PositionManager_increaseLiquidity_erc20_withSettlePair": "158686", - "PositionManager_increaseLiquidity_native": "142853", - "PositionManager_increase_autocompoundExactUnclaimedFees": "137717", - "PositionManager_increase_autocompoundExcessFeesCredit": "179147", - "PositionManager_increase_autocompound_clearExcess": "149061", - "PositionManager_mint_native": "367155", - "PositionManager_mint_nativeWithSweep_withClose": "375927", - "PositionManager_mint_nativeWithSweep_withSettlePair": "375085", - "PositionManager_mint_onSameTickLower": "318686", - "PositionManager_mint_onSameTickUpper": "319328", - "PositionManager_mint_sameRange": "244910", - "PositionManager_mint_settleWithBalance_sweep": "420852", - "PositionManager_mint_warmedPool_differentRange": "324704", - "PositionManager_mint_withClose": "421370", - "PositionManager_mint_withSettlePair": "420354", - "PositionManager_multicall_initialize_mint": "456443", - "PositionManager_permit": "79572", - "PositionManager_permit_secondPosition": "62472", - "PositionManager_permit_twice": "45372", - "PositionManager_subscribe": "87949", - "PositionManager_unsubscribe": "62082", - "position manager initcode hash (without constructor params, as uint256)": "52557493517995128798173618061600371031855775926625542851225012382382780026911", - "positionManager bytecode size": "23643" + "PositionManager_burn_empty": "51102", + "PositionManager_burn_empty_native": "51102", + "PositionManager_burn_nonEmpty_native_withClose": "127695", + "PositionManager_burn_nonEmpty_native_withTakePair": "127137", + "PositionManager_burn_nonEmpty_withClose": "134600", + "PositionManager_burn_nonEmpty_withTakePair": "134043", + "PositionManager_collect_native": "147732", + "PositionManager_collect_sameRange": "156364", + "PositionManager_collect_withClose": "156364", + "PositionManager_collect_withTakePair": "155679", + "PositionManager_decreaseLiquidity_native": "113681", + "PositionManager_decreaseLiquidity_withClose": "121933", + "PositionManager_decreaseLiquidity_withTakePair": "121248", + "PositionManager_decrease_burnEmpty": "137500", + "PositionManager_decrease_burnEmpty_native": "130595", + "PositionManager_decrease_sameRange_allLiquidity": "134649", + "PositionManager_decrease_take_take": "122490", + "PositionManager_increaseLiquidity_erc20_withClose": "160652", + "PositionManager_increaseLiquidity_erc20_withSettlePair": "159563", + "PositionManager_increaseLiquidity_native": "143532", + "PositionManager_increase_autocompoundExactUnclaimedFees": "138231", + "PositionManager_increase_autocompoundExcessFeesCredit": "179593", + "PositionManager_increase_autocompound_clearExcess": "149511", + "PositionManager_mint_native": "367550", + "PositionManager_mint_nativeWithSweep_withClose": "376153", + "PositionManager_mint_nativeWithSweep_withSettlePair": "375348", + "PositionManager_mint_onSameTickLower": "319298", + "PositionManager_mint_onSameTickUpper": "319940", + "PositionManager_mint_sameRange": "245522", + "PositionManager_mint_settleWithBalance_sweep": "420760", + "PositionManager_mint_warmedPool_differentRange": "325316", + "PositionManager_mint_withClose": "421910", + "PositionManager_mint_withSettlePair": "420939", + "PositionManager_multicall_initialize_mint": "458237", + "PositionManager_permit": "79175", + "PositionManager_permit_secondPosition": "62063", + "PositionManager_permit_twice": "44975", + "PositionManager_subscribe": "87968", + "PositionManager_unsubscribe": "62697", + "position manager initcode hash (without constructor params, as uint256)": "81827502601055975118808937107769364319765058198432540518516360048852193272922", + "positionManager bytecode size": "23877" } \ No newline at end of file diff --git a/snapshots/QuoterTest.json b/snapshots/QuoterTest.json index 608ef8b1..a3c80a4f 100644 --- a/snapshots/QuoterTest.json +++ b/snapshots/QuoterTest.json @@ -1,15 +1,15 @@ { - "Quoter_exactInputSingle_oneForZero_multiplePositions": "146722", - "Quoter_exactInputSingle_zeroForOne_multiplePositions": "152948", - "Quoter_exactOutputSingle_oneForZero": "80318", - "Quoter_exactOutputSingle_zeroForOne": "85565", - "Quoter_quoteExactInput_oneHop_1TickLoaded": "123940", - "Quoter_quoteExactInput_oneHop_initializedAfter": "148554", - "Quoter_quoteExactInput_oneHop_startingInitialized": "81829", - "Quoter_quoteExactInput_twoHops": "206923", - "Quoter_quoteExactOutput_oneHop_1TickLoaded": "123618", - "Quoter_quoteExactOutput_oneHop_2TicksLoaded": "154273", - "Quoter_quoteExactOutput_oneHop_initializedAfter": "123645", - "Quoter_quoteExactOutput_oneHop_startingInitialized": "99939", - "Quoter_quoteExactOutput_twoHops": "206951" + "Quoter_exactInputSingle_oneForZero_multiplePositions": "145902", + "Quoter_exactInputSingle_zeroForOne_multiplePositions": "152117", + "Quoter_exactOutputSingle_oneForZero": "79267", + "Quoter_exactOutputSingle_zeroForOne": "84512", + "Quoter_quoteExactInput_oneHop_1TickLoaded": "122728", + "Quoter_quoteExactInput_oneHop_initializedAfter": "147363", + "Quoter_quoteExactInput_oneHop_startingInitialized": "80638", + "Quoter_quoteExactInput_twoHops": "204942", + "Quoter_quoteExactOutput_oneHop_1TickLoaded": "122224", + "Quoter_quoteExactOutput_oneHop_2TicksLoaded": "152879", + "Quoter_quoteExactOutput_oneHop_initializedAfter": "122251", + "Quoter_quoteExactOutput_oneHop_startingInitialized": "98545", + "Quoter_quoteExactOutput_twoHops": "204670" } \ No newline at end of file diff --git a/snapshots/StateViewTest.json b/snapshots/StateViewTest.json index 93105c96..dc141e39 100644 --- a/snapshots/StateViewTest.json +++ b/snapshots/StateViewTest.json @@ -1,12 +1,12 @@ { - "StateView_extsload_getFeeGrowthGlobals": "2376", - "StateView_extsload_getFeeGrowthInside": "8455", - "StateView_extsload_getLiquidity": "1487", - "StateView_extsload_getPositionInfo": "2905", - "StateView_extsload_getPositionLiquidity": "1724", - "StateView_extsload_getSlot0": "1584", - "StateView_extsload_getTickBitmap": "1682", - "StateView_extsload_getTickFeeGrowthOutside": "2734", - "StateView_extsload_getTickInfo": "3068", - "StateView_extsload_getTickLiquidity": "1879" + "StateView_extsload_getFeeGrowthGlobals": "2203", + "StateView_extsload_getFeeGrowthInside": "7875", + "StateView_extsload_getLiquidity": "1439", + "StateView_extsload_getPositionInfo": "2761", + "StateView_extsload_getPositionLiquidity": "1691", + "StateView_extsload_getSlot0": "1486", + "StateView_extsload_getTickBitmap": "1432", + "StateView_extsload_getTickFeeGrowthOutside": "2490", + "StateView_extsload_getTickInfo": "2693", + "StateView_extsload_getTickLiquidity": "1686" } \ No newline at end of file From 6950c8a6ec05e48d2953e69bed17104c926305cd Mon Sep 17 00:00:00 2001 From: saucepoint Date: Wed, 18 Dec 2024 16:53:06 -0500 Subject: [PATCH 8/8] restore new line --- foundry.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundry.toml b/foundry.toml index 780d62c5..55eaaa17 100644 --- a/foundry.toml +++ b/foundry.toml @@ -39,4 +39,4 @@ unichain_sepolia = "https://sepolia.unichain.org" base_sepolia = "https://sepolia.base.org" arbitrum_sepolia = "https://sepolia-rollup.arbitrum.io/rpc" -# See more config options https://github.com/foundry-rs/foundry/tree/master/config \ No newline at end of file +# See more config options https://github.com/foundry-rs/foundry/tree/master/config