Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps have critical security issues #5638

Closed
virbyte opened this issue Jul 12, 2023 · 8 comments
Closed

Deps have critical security issues #5638

virbyte opened this issue Jul 12, 2023 · 8 comments

Comments

@virbyte
Copy link

virbyte commented Jul 12, 2023

WARN  deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
 WARN  deprecated vm2@3.9.19: The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued. Consider migrating your code to isolated-vm.

@boxexchanger
Copy link

Hi, RCE security issue!, Overview
vm2 is a sandbox that can run untrusted code with whitelisted Node's built-in modules.

Affected versions of this package are vulnerable to Remote Code Execution (RCE) such that handler sanitization can be bypassed, allowing attackers to escape the sandbox.

Note:

According to the maintainer, the security issue cannot be properly addressed and the library will be discontinued.

SNYK: https://security.snyk.io/vuln/SNYK-JS-VM2-5772825

@GnipN
Copy link

GnipN commented Jul 16, 2023

For my case:

  1. new install pm2 then got warning as your posted:
    : sudo npm install pm2 -g

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated vm2@3.9.19: The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued. Consider migrating your code to isolated-vm.

  1. update uuid:
    : npm update uuid

up to date, audited 59 packages in 919ms
8 packages are looking for funding
run npm fund for details
found 0 vulnerabilities

  1. recheck vulnerabilities:
    : npm audit

found 0 vulnerabilities


Hope this could help you guys ;)

@OIRNOIR
Copy link

OIRNOIR commented Jul 17, 2023

For my case:

  1. new install pm2 then got warning as your posted:
    : sudo npm install pm2 -g

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. npm WARN deprecated vm2@3.9.19: The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued. Consider migrating your code to isolated-vm.

  1. update uuid:
    : npm update uuid

up to date, audited 59 packages in 919ms 8 packages are looking for funding run npm fund for details found 0 vulnerabilities

  1. recheck vulnerabilities:
    : npm audit

found 0 vulnerabilities

Hope this could help you guys ;)

This only says 0 vulnerabilities because npm audit does not check globally installed packages. Try installing pm2 to a local directory instead.

@mterrel
Copy link

mterrel commented Jul 18, 2023

The proxy-agent dependency just released a new version 6.3.0 that no longer depends on vm2: https://github.com/TooTallNate/proxy-agents/releases

@OIRNOIR
Copy link

OIRNOIR commented Jul 18, 2023

The proxy-agent dependency just released a new version 6.3.0 that no longer depends on vm2: https://github.com/TooTallNate/proxy-agents/releases

Awesome! We can just upgrade proxy-agent to 6.3.0.

@gabrielenosso
Copy link

vm2 critical security issue - same as here: #5643
Need this fixed ASAP for CI/CD Pipeline which recognizes this as a Critical risk

@boxexchanger
Copy link

@Unitech any updates? When it will be fixed?

@OIRNOIR
Copy link

OIRNOIR commented Sep 19, 2023

This is no longer an issue. It can be closed. @virbyte

@virbyte virbyte closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants