Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/settings screen #47

Merged
merged 25 commits into from
Nov 21, 2024
Merged

Feature/settings screen #47

merged 25 commits into from
Nov 21, 2024

Conversation

tonelli-m
Copy link
Collaborator

Description

Adds a settings screen to tweak persistent app settings

Changes

  • Added a crossplaform user settings service to manage persistently stored settings using the Settings Multiplatform library
    • Android settings are stored using SharedPreferences
    • iOS settings are stored using NSUserDefaults
    • Web settings are stored using Storage
    • Any serializable type can be stored, associated to a unique key and a default value
    • Settings values can be retrieved as a one time thing or as a Flow<T> to listen to value changes
  • Added a settings screen with a list of all settings
  • Bumped dependencies to latest versions

Linked issues

#44

Remaining TODOs

UI could still be improved (especially on small phones and on web) but I'm saving this for later when we'll do a general UI/UX improvement work over the whole app to ensure style consistency.

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added KMP Shared Kotlin code Android Android related code iOS iOS related code labels Nov 14, 2024
@nicolas-f
Copy link
Member

@tonelli-m
Copy link
Collaborator Author

@nicolas-f my bad, build is now fixed 👍

I've also set the github actions workflow to also run for PRs targetting the dev branch

@nicolas-f
Copy link
Member

maybe we should remove dev branch and find a way to build only the last release for the github page ?

1 similar comment
@nicolas-f
Copy link
Member

maybe we should remove dev branch and find a way to build only the last release for the github page ?

@nicolas-f nicolas-f merged commit 6f8cfde into dev Nov 21, 2024
6 checks passed
@tonelli-m
Copy link
Collaborator Author

@nicolas-f The github pages release still only applies to the main branch. We can still keep the dev branch to merge features and only merge in main when we want to make a new release.

@tonelli-m tonelli-m deleted the feature/settings-screen branch November 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android related code iOS iOS related code KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants