Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merg Dev to main #51

Merged
merged 27 commits into from
Nov 21, 2024
Merged

merg Dev to main #51

merged 27 commits into from
Nov 21, 2024

Conversation

nicolas-f
Copy link
Member

Description

merge Dev to main

tonelli-m and others added 26 commits August 19, 2024 16:39
- Remove last traces of androidx.material in favour of material3
…s-screen

# Description

Adds a settings screen to tweak persistent app settings

## Changes

- Added a crossplaform user settings service to manage persistently stored settings using the [Settings Multiplatform](https://github.com/russhwolf/multiplatform-settings) library
  - Android settings are stored using `SharedPreferences`
  - iOS settings are stored using `NSUserDefaults`
  - Web settings are stored using `Storage`
  - Any serializable type can be stored, associated to a unique key and a default value
  - Settings values can be retrieved as a one time thing or as a `Flow<T>` to listen to value changes
- Added a settings screen with a list of all settings
- Bumped dependencies to latest versions
 
## Linked issues

#44 

## Remaining TODOs

UI could still be improved (especially on small phones and on web) but I'm saving this for later when we'll do a general UI/UX improvement work over the whole app to ensure style consistency.

## Checklist

- [x] Code compiles correctly on all platforms
- [x] All pre-existing tests are passing
- [x] If needed, new tests have been added
- [x] Extended the README / documentation if necessary
- [x] Added code has been documented
@nicolas-f nicolas-f added the KMP Shared Kotlin code label Nov 21, 2024
@nicolas-f nicolas-f merged commit 7b017da into main Nov 21, 2024
12 checks passed
@nicolas-f nicolas-f deleted the dev branch November 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants