-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merg Dev to main #51
Merged
merg Dev to main #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove last traces of androidx.material in favour of material3
…s-screen # Description Adds a settings screen to tweak persistent app settings ## Changes - Added a crossplaform user settings service to manage persistently stored settings using the [Settings Multiplatform](https://github.com/russhwolf/multiplatform-settings) library - Android settings are stored using `SharedPreferences` - iOS settings are stored using `NSUserDefaults` - Web settings are stored using `Storage` - Any serializable type can be stored, associated to a unique key and a default value - Settings values can be retrieved as a one time thing or as a `Flow<T>` to listen to value changes - Added a settings screen with a list of all settings - Bumped dependencies to latest versions ## Linked issues #44 ## Remaining TODOs UI could still be improved (especially on small phones and on web) but I'm saving this for later when we'll do a general UI/UX improvement work over the whole app to ensure style consistency. ## Checklist - [x] Code compiles correctly on all platforms - [x] All pre-existing tests are passing - [x] If needed, new tests have been added - [x] Extended the README / documentation if necessary - [x] Added code has been documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
merge Dev to main