Improve error handling in controllers #324
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various changes related to error handling in the HTTP controllers, most of which fall into one of two changes:
Controllers.handleError
, which takes care of logging it (with context), as well as rendering an appropriate template. (In the process this also introduces a 500 template.)error
return fromutils.RenderTemplate
, since all callers were just doing alog.Println(err); return
anyway. Instead haveutils
take care of logging it, with appropriate context.Depends on UniversityRadioYork/myradio-go#64.
Fixes #180.