Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added media links feature #385

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Added media links feature #385

wants to merge 1 commit into from

Conversation

praneel1059
Copy link

I had to create new variable name mainTiktok and mainLinkedin underneath the rest of the social media main in config.toml

@hitime1234
Copy link
Contributor

hitime1234 commented Oct 12, 2024

Currently your changes will crash the website because you are missing Qutation marks around the links
You will get the error :
Near` line 71 (last key parsed 'pageContext.youtube.channelURL'): expected value but found "https" instead make: *** [Makefile:17: run] Error 1
Good first effort however

@hitime1234
Copy link
Contributor

I had to create new variable name mainTiktok and mainLinkedin underneath the rest of the social media main in config.toml

Consider adding the new variables to contact page dm me on slack if want to test adding this to the main website:

structs/config.go
views/elements/contact.tmpl

this isn't needed for this pr but nice to have

See #363 as a example on how to add a new variable to the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants