Skip to content

Commit

Permalink
Remove dependency in urigo:angular and release new version
Browse files Browse the repository at this point in the history
  • Loading branch information
Urigo committed Jan 11, 2015
1 parent 10341ff commit 9411e5c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 16 deletions.
3 changes: 1 addition & 2 deletions .versions
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
meteor@1.1.4
mquandalle:bower@0.1.11
underscore@1.0.2
urigo:angular@0.6.0-alpha
urigo:ionic@0.1.0
urigo:ionic@0.2.0
5 changes: 1 addition & 4 deletions init.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,4 @@ if (Package.fastclick) {
Package.fastclick.FastClick.notNeeded = function() {
return true;
};
}

// add 'ionic' angular module as dependency
angularMeteor.requires.push('ionic');
}
11 changes: 2 additions & 9 deletions package.js
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
Package.describe({
summary: "Ionic framework packaged for Meteor.",
version: "0.1.0",
version: "0.2.0",
git: "https://github.com/Urigo/meteor-ionic.git"
});

Package.on_use(function (api, where) {
api.versionsFrom('METEOR@0.9.0.1');
api.use([
'urigo:angular@0.6.0-alpha',
'mquandalle:bower@0.1.11'],
'client');
api.use('mquandalle:bower@0.1.11', 'client');

api.use([
'fastclick@1.0.1'
], 'client', {weak : true});

api.imply([
'urigo:angular'
]);

// Add bower
api.addFiles('smart.json', 'client');

Expand Down
2 changes: 1 addition & 1 deletion smart.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"homepage": "https://github.com/urigo/meteor-ionic",
"author": "Uri Goldshtein <uri.goldshtein@gmail.com> & Marc Rovira <marcrvall@gmail.com>",
"git": "https://github.com/urigo/meteor-ionic.git",
"version": "0.0.7",
"version": "0.2.0",
"packages": {
"bower": {}
},
Expand Down

3 comments on commit 9411e5c

@netanelgilad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urigo Why did you remove the dependency? It means that ionic can get loaded before angular and that's bad... That happens right now at our project...

@netanelgilad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you really want to remove the dependency than maybe a weak dependency would be better?

@Urigo
Copy link
Owner Author

@Urigo Urigo commented on 9411e5c Jan 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netanelgilad you are right.

I've added a weak dependency

Please sign in to comment.