Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change isPublic to be a filterable tag for studies and control release of studies #35

Open
SheenaTomko opened this issue Mar 4, 2022 · 1 comment
Labels
enhancement New feature or request medium cost

Comments

@SheenaTomko
Copy link
Contributor

SheenaTomko commented Mar 4, 2022

Right now we have 2 sets of qa sites, qa.clinepidb and qa.restricted.clinepidb. The only difference that I know of is that qa.clinepidb is restricted to show only studies where “isPublic” in the presenters is set to “true”. We don't really need the 2 different versions of the sites, but we do need a way to easily check which studies will be public with a release and which will remain on qa.

Brian suggested that we turn “isPublic” into a tag that we can use to filter on in the study summaries table as a way to check which studies will go out with a release. This would likely require service/client work to make sure all studies appear on the qa site, they are filterable based on the isPublic attribute, and that only those set to isPublic = true are accessible on the live site. However, if we make this change, it will allow us to get rid of qa.restricted.clinepidb.org and simplify things for the Systems and Outreach teams.

As part of this ticket, we could change the name of the annotation "isPublic" to "isReleased" to more clearly differentiate it from the data access level restrictions.

@aurreco-uga
Copy link
Member

the currently proposed plan is (1) to add a model property that will be different in production vs development/qa. (2) The "all studies" SQL will use this property and the isPublic attribute to determine which studies to hide in this website. (3) The client wont have to do anything (Currently checking on projectid to determine which studies to hide).
(4) no work needed in backend.

@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Apr 12, 2022
@danicahelb danicahelb added enhancement New feature or request b58 labels Apr 12, 2022
@bobular bobular removed the b58 label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium cost
Projects
None yet
Development

No branches or pull requests

5 participants