Enum fixes #70
Merged
Enum fixes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrdoherty
requested review from
aurreco-uga,
bgajria and
steve-fischer-200
| @@ -512,6 +513,19 @@ String getValuesForSignature() { | |||
|
|
|||
| abstract List<?> getSortedMembers(); | |||
|
|
|||
| protected <T> String createInCondition(String metadataTableName, String columnName, List<T> membersList) { | |||
There was a problem hiding this comment.
Is there any possibility that the strategy of multiple IN large in clauses will blow up the query planner?
There was a problem hiding this comment.
At least currently, this is an edge case (fungi has 1118 strains) so splitting one in clause into two is probably ok. We could potentially see long running jobs in the future if for some reason we have many thousands of options in a membership filter, but we should be able to see that in the SQL and can address if it happens. For now it is fine.
aurreco-uga
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two separate issues (combined only for testing convenience):
The issue at the bottom of https://redmine.apidb.org/issues/12938, namely for the
refreshed-dependent-paramsendpoint to throw 422 instead of 500 in the following instance:a. Param A is a multi-pick enum param requiring >0 selected terms in a runnable context (but not displayable context)
b. Param B is a filter param (enum would also have this problem) which depends on A and whose vocabulary queries cannot support an empty value (no selected terms) for Param A
c. User clicks "Select None" in Param A, triggering a call to
refreshed-dependent-paramsto get the new vocabulary and default value for Param BThe issue described in https://redmine.apidb.org/issues/51649, namely that membership filters in filter params cannot handle >1000 terms (SQL breaks Oracle's 1000 term limit in
inclauses).