Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization scheme should raise an exception when the user_id is not in the JWT payload #59

Open
joeribekker opened this issue Jun 13, 2019 · 3 comments
Assignees

Comments

@joeribekker
Copy link
Collaborator

The JWT payload attribute user_id is mandatory, see also: https://github.com/VNG-Realisatie/gemma-zaken/blob/master/docs/_content/standaard/standaard.md#autorisatie

def payload(self) -> dict:

@annashamray
Copy link
Collaborator

According to this doc user_id can be absent:
"Indien deze claim niet aanwezig is, wordt de X-NLX-Request-User-Id uitgelezen."

@joeribekker
Copy link
Collaborator Author

Good observation! We need to resolve this documentation conflict.

@sergei-maertens
Copy link
Collaborator

This is a breaking change - also because we need to update the API spec w/r to the NLX headers (that aren't supported after all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants