Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Documentation on Variant Generators #77

Open
pmbittner opened this issue Oct 9, 2024 · 0 comments · May be fixed by #78
Open

Fix Documentation on Variant Generators #77

pmbittner opened this issue Oct 9, 2024 · 0 comments · May be fixed by #78
Assignees
@ibbem
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@pmbittner
Copy link
Member

There are still some places in the documentation where we use the term "variant map". However, in the code and the paper, we renamed this term to "variant generator". The occurrences in the documentation should be renamed as well.
@pmbittner pmbittner added bug Something isn't working documentation Improvements or additions to documentation labels Oct 9, 2024
ibbem added a commit that referenced this issue Nov 15, 2024
@ibbem
Rename VariantMap to VariantGenerator in the documentation
2fe184e 
During the actual rename in 2549a48, I
missed the documentation which is fixed by this commit. Now, there
should be no occurrences of variant map anymore.

Fixes #77
@ibbem ibbem linked a pull request Nov 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibbem ibbem

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename "variant map" to "variant generator" in the documentation VariantSync/Vatras
2 participants
@pmbittner @ibbem