fix(github): Infinite loop when fetching tags

ViBiOh · May 23, 2020 · 04e0b9c · 04e0b9c
1 parent 02c3b85
commit 04e0b9c
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/pkg/github/github.go b/pkg/github/github.go
@@ -91,7 +91,7 @@ func (a app) parseTags(repository string) (semver.Version, error) {
 			}
 		}
 
-		if !isLastPage(resp) {
+		if !hasNext(resp) {
 			break
 		}
 
@@ -105,6 +105,12 @@ func (a app) parseTags(repository string) (semver.Version, error) {
 	return version, nil
 }
 
-func isLastPage(resp *http.Response) bool {
-	return !strings.Contains(resp.Header.Get("Link"), `rel="next"`)
+func hasNext(resp *http.Response) bool {
+	for _, value := range resp.Header.Values("Link") {
+		if strings.Contains(value, `rel="next"`) {
+			return true
+		}
+	}
+
+	return false
 }