Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7 Third-person blocking pose #563

Open
AndrewScripter587 opened this issue Sep 15, 2024 · 8 comments
Open

1.7 Third-person blocking pose #563

AndrewScripter587 opened this issue Sep 15, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@AndrewScripter587
Copy link

Problem Description

When playing on a MC beta 1.8 to release 1.7.10 server, the release 1.8 third-person sword blocking pose is used, when prior MC versions to 1.8 had a different third-person blocking pose.

Solution Description

I would like the 1.7 and older 3rd person blocking pose to be added and used on 1.7 and older servers.

Alternatives

No response

Additional Info

No response

@AndrewScripter587 AndrewScripter587 added the enhancement New feature or request label Sep 15, 2024
@FlorianMichael
Copy link
Member

Provide your VFP version as well as all installed mods

@AndrewScripter587
Copy link
Author

Ok, my VFP version is 3.4.5, and here's a command prompt directory listing of my mods folder since i'm too lazy to actually write down a list:
appleskin-fabric-mc1.21-3.0.5.jar
authme-8.0.0+1.21.jar
BetterF3-11.0.2-Fabric-1.21.1.jar
BetterPingDisplay-Fabric-1.21.1-1.1.1.jar
chat_heads-0.13.0-fabric-1.21.jar
cloth-config-15.0.130-fabric.jar
fabric-api-0.104.0+1.21.1.jar
iris-fabric-1.8.0-beta.3+mc1.21.1.jar
justzoom_fabric_2.0.0_MC_1.21-1.21.1.jar
konkrete_fabric_1.9.9_MC_1.21.jar
modelfix-1.21-1.6-fabric.jar (Model Gap Fix)
modmenu-11.0.2.jar
morechathistory-1.3.1.jar
MouseTweaks-fabric-mc1.21-2.26.jar
NBTac-FABRIC-1.21.1-1.3.4.jar (NBT Autocomplete)
placeholder-api-2.4.1+1.21.jar
skinlayers3d-fabric-1.6.7-mc1.21.jar
sodium-extra-fabric-0.6.0-beta.1+mc1.21.1.jar
sodium-fabric-0.6.0-beta.1+mc1.21.jar
ViaFabricPlus-3.4.5.jar
waveycapes-fabric-1.4.9-mc1.21.jar

@FlorianMichael
Copy link
Member

Can you try this version? I introduced some changes since the last release (3.4.5)

@AndrewScripter587
Copy link
Author

AndrewScripter587 commented Sep 15, 2024

The blocking pose is still the 1.8 pose on a 1.7 server when 1.7 is selected in VFP in the one in the link you provided. Here's some images for comparison (first 3 are vanilla 1.7's blocking pose from various angles from the front and the 4th is the ViaFabricPlus blocking pose, which is 1.8's, from the front):
2024-09-15_15 20 47
2024-09-15_15 20 50
2024-09-15_15 20 40
2024-09-15_15 23 33

@lowercasebtw
Copy link
Collaborator

I was planning on working on this, but I haven't been able to convert the 1.7 code properly yet

@AndrewScripter587
Copy link
Author

I was planning on working on this, but I haven't been able to convert the 1.7 code properly yet

Makes sense, it is usually hard to port these kinds of things.

@lowercasebtw
Copy link
Collaborator

lowercasebtw commented Sep 15, 2024

Yea, 1.9+ changed how the positioning stuff worked and the same values don't work the same anymore, and requires re-working/finding what causes the difference in values

@AndrewScripter587
Copy link
Author

Yeah, changing certain methods for stuff has its pros and cons (especially for a large game like Minecraft), like a pro may be making it easier to change and build on top of, but a con being something like this, where certain values don't work the same as they did anymore, making backwards/forwards compatibility, among other things, much harder to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants