Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make promscrape.cluster.membersCount discoverable #6842

Open
AndrewChubatiuk opened this issue Aug 20, 2024 · 0 comments
Open

Make promscrape.cluster.membersCount discoverable #6842

AndrewChubatiuk opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request vmagent

Comments

@AndrewChubatiuk
Copy link
Contributor

Is your feature request related to a problem? Please describe

VMAgent sharding requires setting -promscrape.cluster.membersCount flag, which should be updated every time deployment/statefulset scales up or down, which requires all pods to be recreated. Being able to discover this value dynamically would help to cope with this issue

Related issues VictoriaMetrics/operator#924, VictoriaMetrics/operator#1101

Describe the solution you'd like

Add interface and some implementations of this interface for K8s, Consul, etc with flags or configuration file, that helps to provide additional settings for each of discovery mechanisms which can be enabled instead of setting a static -promscrape.cluster.membersCount value

Describe alternatives you've considered

No response

Additional information

No response

@AndrewChubatiuk AndrewChubatiuk added the enhancement New feature or request label Aug 20, 2024
@AndrewChubatiuk AndrewChubatiuk changed the title Make promscrape.cluster.membersCount disoverable Make promscrape.cluster.membersCount discoverable Aug 20, 2024
@jiekun jiekun added the vmagent label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vmagent
Projects
None yet
Development

No branches or pull requests

2 participants