Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incase of error, handle error #2

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

SpcFORK
Copy link
Contributor

@SpcFORK SpcFORK commented Jun 27, 2024

runtime/voxel.c: In function ‘main’:
runtime/voxel.c:34:5: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   34 |     fread(data, sizeof(char), size, fp);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

```shell
runtime/voxel.c: In function ‘main’:
runtime/voxel.c:34:5: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   34 |     fread(data, sizeof(char), size, fp);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Copy link
Contributor

@James-Livesey James-Livesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes that I'd recommend making, but otherwise LGTM!

runtime/voxel.c Outdated Show resolved Hide resolved
runtime/voxel.c Outdated Show resolved Hide resolved
@SpcFORK
Copy link
Contributor Author

SpcFORK commented Jun 27, 2024

Fixed! No more double read.

@James-Livesey James-Livesey added the bug Something isn't working label Jun 27, 2024
Copy link
Contributor

@James-Livesey James-Livesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, all good from me — thanks for contributing! Will merge now 👍

@James-Livesey James-Livesey merged commit be7c3bc into Voxellius:main Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants